[BUG] Unassigned values read over WebAPI fail to parse (#219)

* Create draft PR for #217

* wip

* adds response check due to unassigned CHAR and WCHAR not appearing in the resutls when reading

---------

Co-authored-by: PTKu <[email protected]>
Co-authored-by: PTKu <[email protected]>

Author: IX-BOT

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiBool.cs

@@ -66,7 +66,10 @@ ApiPlcWriteRequest IWebApiPrimitive.PlcWriteRequestData
     /// <inheritdoc />
     public void Read(string value)
     {
-        UpdateRead(bool.Parse(value));
+        if (bool.TryParse(value, out var val))
+        {
+            UpdateRead(val);
+        }
     }
 
     /// <inheritdoc />

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiByte.cs

@@ -6,6 +6,7 @@
 // Third party licenses: https://github.com/ix-ax/axsharp/blob/master/notices.md
 
 using AXSharp.Connector.ValueTypes;
+using Newtonsoft.Json.Linq;
 
 namespace AXSharp.Connector.S71500.WebApi;
 
@@ -64,9 +65,12 @@ ApiPlcWriteRequest IWebApiPrimitive.PlcWriteRequestData
     }
 
     /// <inheritdoc />
-    public void Read(string result)
+    public void Read(string value)
     {
-        UpdateRead(byte.Parse(result));
+        if (byte.TryParse(value, out var val))
+        {
+            UpdateRead(val);
+        }
     }
 
     /// <inheritdoc />

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiChar.cs

@@ -71,7 +71,10 @@ ApiPlcWriteRequest IWebApiPrimitive.PlcWriteRequestData
     /// <inheritdoc />
     public void Read(string value)
     {
-        UpdateRead(char.Parse(value));
+        if (char.TryParse(value, out var val))
+        {
+            UpdateRead(val);
+        }
     }
 
     /// <inheritdoc />

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiDInt.cs

@@ -66,7 +66,10 @@ ApiPlcWriteRequest IWebApiPrimitive.PlcWriteRequestData
     /// <inheritdoc />
     public void Read(string value)
     {
-        UpdateRead(int.Parse(value));
+        if (int.TryParse(value, out var val))
+        {
+            UpdateRead(val);
+        }
     }
 
 

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiDWord.cs

@@ -66,7 +66,10 @@ ApiPlcWriteRequest IWebApiPrimitive.PlcWriteRequestData
     /// <inheritdoc />
     public void Read(string value)
     {
-        UpdateRead(uint.Parse(value));
+        if (uint.TryParse(value, out var val))
+        {
+            UpdateRead(val);
+        }
     }
 
     /// <inheritdoc />

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiDate.cs

@@ -77,8 +77,12 @@ public override async Task<DateOnly> GetAsync()
 
     private DateOnly GetFromBinary(string value)
     {
-        var val = long.Parse(value);
-        return GetFromBinary(val);
+        if (long.TryParse(value, out var val))
+        {
+            return GetFromBinary(val);
+        }
+
+        return DateOnly.MinValue;
     }
 
     private DateOnly GetFromBinary(long value)

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiDateTime.cs

@@ -6,6 +6,7 @@
 // Third party licenses: https://github.com/ix-ax/axsharp/blob/master/notices.md
 
 using AXSharp.Connector.ValueTypes;
+using Newtonsoft.Json.Linq;
 
 namespace AXSharp.Connector.S71500.WebApi;
 
@@ -75,9 +76,14 @@ public override async Task<DateTime> GetAsync()
         return await _webApiConnector.ReadAsync<DateTime>(this);
     }
 
-    private DateTime GetFromBinary(string val)
+    private DateTime GetFromBinary(string value)
     {
-        return GetFromBinary(long.Parse(val));
+        if (long.TryParse(value, out var val))
+        {
+            return GetFromBinary(val);
+        }
+
+        return DateTime.MinValue;
     }
 
     private DateTime GetFromBinary(long val)

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiInt.cs

@@ -66,7 +66,10 @@ ApiPlcWriteRequest IWebApiPrimitive.PlcWriteRequestData
     /// <inheritdoc />
     public void Read(string value)
     {
-        UpdateRead(short.Parse(value));
+        if (short.TryParse(value, out var val))
+        {
+            UpdateRead(val);
+        }
     }
 
     /// <inheritdoc />

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiLDate.cs

@@ -78,8 +78,7 @@ public override async Task<DateOnly> GetAsync()
 
     private DateOnly GetFromBinary(string value)
     {
-        var val = long.Parse(value);
-        return GetFromBinary(val);
+        return long.TryParse(value, out var val) ? GetFromBinary(val) : DateOnly.MinValue;
     }
 
     private DateOnly GetFromBinary(long value)

src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiLDateTime.cs

@@ -6,6 +6,7 @@
 // Third party licenses: https://github.com/ix-ax/axsharp/blob/master/notices.md
 
 using AXSharp.Connector.ValueTypes;
+using Newtonsoft.Json.Linq;
 
 namespace AXSharp.Connector.S71500.WebApi;
 
@@ -75,9 +76,9 @@ public override async Task<DateTime> GetAsync()
         return await _webApiConnector.ReadAsync<DateTime>(this);
     }
 
-    private DateTime GetFromBinary(string val)
+    private DateTime GetFromBinary(string value)
     {
-        return GetFromBinary(long.Parse(val));
+        return long.TryParse(value, out var val) ? GetFromBinary(val) : DateTime.MinValue;
     }
 
     private DateTime GetFromBinary(long val)