Skip to content

Commit 9881721

Browse files
authored
Merge pull request #1210 from thewtex/dev-docker-tag
dev docker tag
2 parents d07d12b + ca5c12d commit 9881721

File tree

12 files changed

+36
-25
lines changed

12 files changed

+36
-25
lines changed

examples/debugging/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66
"build": "npm run native-build && npm run emscripten-build-release && npm run emscripten-build-debug && npm run wasi-build-release && npm run wasi-build-debug",
77
"native-build": "cmake -Bbuild -S. -DCMAKE_BUILD_TYPE=Debug && cmake --build build/ --config Debug",
88
"native-debug-linux": "gdb --args ./build/DebugMe",
9-
"emscripten-build-release": "itk-wasm --build-dir emscripten-build-release build",
9+
"emscripten-build-release": "itk-wasm -i itkwasm/emscripten:latest --build-dir emscripten-build-release build",
1010
"run-node-release": "node ./runEmscriptenNode.js ./emscripten-build-release/DebugMe",
11-
"emscripten-build-debug": "itk-wasm --build-dir emscripten-build-debug build -- -DCMAKE_BUILD_TYPE=Debug",
11+
"emscripten-build-debug": "itk-wasm -i itkwasm/emscripten:latest-debug --build-dir emscripten-build-debug build -- -DCMAKE_BUILD_TYPE=Debug",
1212
"run-node-debug": "node ./runEmscriptenNode.js ./emscripten-build-debug/DebugMe",
1313
"wasi-build-release": "itk-wasm -i itkwasm/wasi:latest --build-dir wasi-build-release build",
1414
"node-inspect": "node --inspect-brk ./runEmscriptenNode.js ./emscripten-build-debug/DebugMe",
15-
"wasi-build-debug": "itk-wasm -i itkwasm/wasi --build-dir wasi-build-debug build -- -DCMAKE_BUILD_TYPE=Debug",
15+
"wasi-build-debug": "itk-wasm -i itkwasm/wasi:latest-debug --build-dir wasi-build-debug build -- -DCMAKE_BUILD_TYPE=Debug",
1616
"run-wasi-debug": "itk-wasm --build-dir wasi-build-debug run DebugMe.wasi.wasm",
1717
"start": "http-server -o"
1818
},

examples/inputs-outputs/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
"test:python:dispatch": "itk-wasm pnpm-script test:python:emscripten",
3737
"test:python": "itk-wasm pnpm-script test:python",
3838
"test": "pnpm test:wasi && pnpm test:wasi:help",
39-
"test:wasi": "itk-wasm -b wasi-build run inputs-outputs.wasi.wasm -- -- cthead1.png smoothed.png",
40-
"test:wasi:help": "itk-wasm -b wasi-build run inputs-outputs.wasi.wasm -- -- --help"
39+
"test:wasi": "itk-wasm -i itkwasm/wasi:latest -b wasi-build run inputs-outputs.wasi.wasm -- -- cthead1.png smoothed.png",
40+
"test:wasi:help": "itk-wasm -i itkwasm/wasi:latest -b wasi-build run inputs-outputs.wasi.wasm -- -- --help"
4141
},
4242
"author": "Matt McCormick <[email protected]>",
4343
"license": "Apache-2.0",

examples/mean-squares-versor-registration/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"test:python": "itk-wasm pnpm-script test:python",
3838
"test": "pnpm test:wasi:help",
3939
"test:wasi:long": "itk-wasm test -- -- -V",
40-
"test:wasi:help": "itk-wasm run mean-squares-versor-registration.wasi.wasm -- -- --help"
40+
"test:wasi:help": "itk-wasm -i itkwasm/wasi:latest run mean-squares-versor-registration.wasi.wasm -- -- --help"
4141
},
4242
"author": "Matt McCormick <[email protected]>",
4343
"license": "Apache-2.0",

itk_wasm_env.bash

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ if test "$OSTYPE" = "cygwin" || test "$OSTYPE" = "msys" || test "$OSTYPE" = "win
1010
export CXXFLAGS="/Zc:__cplusplus /Zc:preprocessor /DNOMINMAX"
1111
fi
1212

13+
export ITK_WASM_DEV_DOCKER_TAG=${ITK_WASM_DEV_DOCKER_TAG:-$(echo $(date '+%Y%m%d')-$(git rev-parse --short HEAD))}
14+
1315
export ITK_WASM_DCMTK_REPOSITORY=${ITK_WASM_DCMTK_REPOSITORY:-"https://github.com/InsightSoftwareConsortium/DCMTK"}
1416
export ITK_WASM_DCMTK_GIT_TAG=${ITK_WASM_DCMTK_GIT_TAG:-"93e6d1b20b476c388f0379245c8c6e96af7f16f4"}
1517

packages/core/typescript/itk-wasm/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@
4343
"test:buildTestPipelines:emscripten": "node src/itk-wasm-cli.js -i itkwasm/emscripten:latest -b emscripten-build -s ./test/pipelines build",
4444
"test:buildTestPipelines:wasi": "node src/itk-wasm-cli.js -i itkwasm/wasi:latest -b wasi-build -s ./test/pipelines build",
4545
"test:buildTestPipelines:wasi:debug": "node src/itk-wasm-cli.js -i itkwasm/wasi:latest-debug -b wasi-build -s ./test/pipelines build -- -DCMAKE_BUILD_TYPE=Debug",
46-
"test:runTestPipelines": "node src/itk-wasm-cli.js -b wasi-build -s ./test/pipelines run -r wasmtime stdout-stderr-pipeline/stdout-stderr-test.wasi.wasm",
47-
"test:bindgenTestPipelines:typescript": "node src/itk-wasm-cli.js -b emscripten-build -s ./test/pipelines/ bindgen --package-version 1.0.0 --package-name test-pipelines --package-description \"Exercise interface types for bindgen\"",
48-
"test:bindgenTestPipelines:python": "node src/itk-wasm-cli.js -b wasi-build -s ./test/pipelines/ bindgen --interface python --package-version 1.0.0 --package-name test-pipelines --package-description \"Exercise interface types for bindgen\"",
46+
"test:runTestPipelines": "node src/itk-wasm-cli.js -i itkwasm/wasi:latest -b wasi-build -s ./test/pipelines run -r wasmtime stdout-stderr-pipeline/stdout-stderr-test.wasi.wasm",
47+
"test:bindgenTestPipelines:typescript": "node src/itk-wasm-cli.js -i itkwasm/emscripten:latest -b emscripten-build -s ./test/pipelines/ bindgen --package-version 1.0.0 --package-name test-pipelines --package-description \"Exercise interface types for bindgen\"",
48+
"test:bindgenTestPipelines:python": "node src/itk-wasm-cli.js -i itkwasm/wasi:latest -b wasi-build -s ./test/pipelines/ bindgen --interface python --package-version 1.0.0 --package-name test-pipelines --package-description \"Exercise interface types for bindgen\"",
4949
"test:browser:debug": "start-server-and-test start http-get://localhost:5180 cypress:open",
5050
"test:cypress": "start-server-and-test start http-get://localhost:5180 cypress:run",
5151
"test:browser:chrome": "start-server-and-test start http-get://localhost:5180 cypress:runChrome",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
const defaultImageTag = '20240822-c390b350'
1+
const defaultImageTag = '20240825-1a89d0e6'
22
export default defaultImageTag

packages/core/typescript/itk-wasm/src/cli/pnpm-script.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,13 @@ async function pnpmScript(name, extraArgs, options) {
193193
undefined,
194194
true
195195
)
196+
const emscriptenDockerImage =
197+
configValue(
198+
'emscripten-docker-image',
199+
options,
200+
packageJson,
201+
undefined
202+
) ?? `quay.io/itkwasm/emscripten:${defaultImageTag}`
196203
const packageDescription = configValue(
197204
'package-description',
198205
options,
@@ -204,6 +211,8 @@ async function pnpmScript(name, extraArgs, options) {
204211
'itk-wasm',
205212
'-b',
206213
'emscripten-build',
214+
'-i',
215+
emscriptenDockerImage,
207216
'bindgen',
208217
'--interface',
209218
'typescript',
@@ -247,10 +256,15 @@ async function pnpmScript(name, extraArgs, options) {
247256
undefined,
248257
true
249258
)
259+
const wasiDockerImage =
260+
configValue('wasi-docker-image', options, packageJson, undefined) ??
261+
`quay.io/itkwasm/wasi:${defaultImageTag}`
250262
pnpmCommand = pnpmCommand.concat([
251263
'itk-wasm',
252264
'-b',
253265
'wasi-build',
266+
'-i',
267+
wasiDockerImage,
254268
'bindgen',
255269
'--interface',
256270
'python',

packages/dicom/python/itkwasm-dicom-emscripten/itkwasm_dicom_emscripten/js_package.py

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

packages/transform-io/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"description": "scripts to generate @itk-wasm/transform-io itk-wasm artifacts.",
77
"type": "module",
88
"itk-wasm": {
9-
"emscripten-docker-transform": "itkwasm/emscripten:latest",
10-
"wasi-docker-transform": "itkwasm/wasi:latest",
9+
"emscripten-docker-image": "itkwasm/emscripten:latest",
10+
"wasi-docker-image": "itkwasm/wasi:latest",
1111
"typescript-package-name": "@itk-wasm/transform-io",
1212
"python-package-name": "itkwasm-transform-io",
1313
"package-description": "Input and output for scientific and medical coordinate transform file formats.",

pixi.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ inputs = ["itk_wasm_env.*"]
3636
description = "Provide ITK_WASM environmental variables to the Docker image"
3737

3838
[tasks.update-default-image-tag]
39-
cmd = "sed -i \"s/const defaultImageTag = '.*'/const defaultImageTag = '$new_tag'/g\" packages/core/typescript/itk-wasm/src/cli/default-image-tag.js"
39+
cmd = "sed -i \"s/const defaultImageTag = '.*'/const defaultImageTag = '$ITK_WASM_DEV_DOCKER_TAG'/g\" packages/core/typescript/itk-wasm/src/cli/default-image-tag.js"
4040
outputs = ["packages/core/typescript/itk-wasm/src/cli/default-image-tag.*"]
4141
description = "Update the default Docker image tag"
4242

0 commit comments

Comments
 (0)