temporary commit for sonar test

Author: hirokuni-kitahara

integrity-shield-operator/api/v1alpha1/integrityshield_types.go

@@ -55,7 +55,7 @@ const (
 	DefaultResourceSigningProfileYamlPath     = "./resources/default-rsp.yaml"
 	DefaultKeyringFilename                    = "pubring.gpg"
 	DefaultIShieldWebhookTimeout              = 10
-	SATokenPath                               = "/var/run/secrets/kubernetes.io/serviceaccount/token"
+	SATokenPath                               = "/var/run/secrets/kubernetes.io/serviceaccount/token" //NOSONAR
 )
 
 // EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!

integrity-shield-operator/cert/cert.go

@@ -53,13 +53,13 @@ func GenerateCert(svcName, NS string) ([]byte, []byte, []byte, error) {
 		return nil, nil, nil, err
 	}
 	caPEM := new(bytes.Buffer)
-	pem.Encode(caPEM, &pem.Block{
+	_ = pem.Encode(caPEM, &pem.Block{
 		Type:  "CERTIFICATE",
 		Bytes: caBytes,
 	})
 
 	caKeyPEM := new(bytes.Buffer)
-	pem.Encode(caKeyPEM, &pem.Block{
+	_ = pem.Encode(caKeyPEM, &pem.Block{
 		Type:  "RSA PRIVATE KEY",
 		Bytes: x509.MarshalPKCS1PrivateKey(caKey),
 	})
@@ -71,7 +71,7 @@ func GenerateCert(svcName, NS string) ([]byte, []byte, []byte, error) {
 	}
 
 	tlsPrivKeyPEM := new(bytes.Buffer)
-	pem.Encode(tlsPrivKeyPEM, &pem.Block{
+	_ = pem.Encode(tlsPrivKeyPEM, &pem.Block{
 		Type:  "RSA PRIVATE KEY",
 		Bytes: x509.MarshalPKCS1PrivateKey(tlsKey),
 	})
@@ -94,7 +94,7 @@ func GenerateCert(svcName, NS string) ([]byte, []byte, []byte, error) {
 		return nil, nil, nil, err
 	}
 	certPEM := new(bytes.Buffer)
-	pem.Encode(certPEM, &pem.Block{
+	_ = pem.Encode(certPEM, &pem.Block{
 		Type:  "CERTIFICATE",
 		Bytes: certBytes,
 	})

integrity-shield-operator/pgpkey/pgpkey.go

@@ -21,6 +21,7 @@ import (
 	"fmt"
 	"io/ioutil"
 	"os"
+	"path/filepath"
 
 	"golang.org/x/crypto/openpgp"
 )
@@ -92,7 +93,7 @@ func CreateKeyringFile(path string, signers []string, invalidSigners []string) e
 	if err != nil {
 		return errors.New(fmt.Sprintf("Error in creating private keyring file; %s", err.Error()))
 	}
-	defer secfile.Close()
+	defer secfile.Close() //NOSONAR
 
 	for _, ent := range entList {
 		err := ent.SerializePrivate(secfile, nil)
@@ -105,7 +106,7 @@ func CreateKeyringFile(path string, signers []string, invalidSigners []string) e
 	if err != nil {
 		return errors.New(fmt.Sprintf("Error in creating public keyring file; %s", err.Error()))
 	}
-	defer pubfile.Close()
+	defer pubfile.Close() //NOSONAR
 
 	for _, ent := range entList {
 		idt := getFirstIdentity(ent.Identities)
@@ -122,12 +123,12 @@ func CreateKeyringFile(path string, signers []string, invalidSigners []string) e
 }
 
 func GetKeyringValue(path string) (*Keyring, error) {
-	rawPub, err := ioutil.ReadFile(path + defaultPublicKeyringName)
+	rawPub, err := ioutil.ReadFile(filepath.Clean(path + defaultPublicKeyringName))
 	if err != nil {
 		return nil, errors.New(fmt.Sprintf("Error in getting value of public keyring; %s", err.Error()))
 	}
 
-	rawSec, err := ioutil.ReadFile(path + defaultPrivateKeyringName)
+	rawSec, err := ioutil.ReadFile(filepath.Clean(path + defaultPrivateKeyringName))
 	if err != nil {
 		return nil, errors.New(fmt.Sprintf("Error in getting value private keyring; %s", err.Error()))
 	}

integrity-shield-operator/resources/utils.go

@@ -20,6 +20,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io/ioutil"
+	"path/filepath"
 	"reflect"
 	"strings"
 
@@ -86,7 +87,7 @@ func MergeDefaultIntegrityShieldCR(cr *apiv1alpha1.IntegrityShield, srcYamlPath
 	if srcYamlPath == "" {
 		srcYamlPath = apiv1alpha1.DefaultIShieldCRYamlPath
 	}
-	deafultCRBytes, _ := ioutil.ReadFile(srcYamlPath)
+	deafultCRBytes, _ := ioutil.ReadFile(filepath.Clean(srcYamlPath))
 	defaultCRJsonBytes, err := yaml.YAMLToJSON(deafultCRBytes)
 	if err != nil {
 		fmt.Println("failed to convert yaml2json; " + err.Error())

sonar-project.properties

@@ -1,7 +1,7 @@
 sonar.projectKey=open-cluster-management_integrity-shield
 sonar.projectName=integrity-shield
 sonar.sources=.
-sonar.exclusions=**/*_test.go,**/*_generated*.go,**/*_generated/**,**/vendor/**,**/e2e/**,**/test/**
+sonar.exclusions=**/*_test.go,**/*_generated*.go,**/*_generated/**,**/vendor/**,**/e2e/**,**/test/**,shield/pkg/apis/**
 sonar.tests=.
 sonar.test.inclusions=**/*_test.go
 sonar.test.exclusions=**/*_generated*.go,**/*_generated/**,**/vendor/**,**/e2e/**,**/test/**