Skip to content

Commit 91e9def

Browse files
committed
avoid some sorting calls
1 parent 8afe95c commit 91e9def

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/main/java/org/htmlunit/html/HtmlPage.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2917,12 +2917,12 @@ private static final class MappedElementIndexEntry implements Serializable {
29172917
MappedElementIndexEntry() {
29182918
// we do not expect to many elements having the same id/name
29192919
elements_ = new ArrayList<>(2);
2920-
sorted_ = false;
2920+
sorted_ = true;
29212921
}
29222922

29232923
void add(final DomElement element) {
29242924
elements_.add(element);
2925-
sorted_ = false;
2925+
sorted_ = elements_.size() < 2;
29262926
}
29272927

29282928
DomElement first() {
@@ -2941,7 +2941,7 @@ DomElement first() {
29412941
}
29422942

29432943
List<DomElement> elements() {
2944-
if (sorted_ || elements_.isEmpty()) {
2944+
if (sorted_) {
29452945
return elements_;
29462946
}
29472947

@@ -2951,8 +2951,9 @@ List<DomElement> elements() {
29512951
return elements_;
29522952
}
29532953

2954-
boolean remove(final DomElement element) {
2955-
return elements_.remove(element);
2954+
void remove(final DomElement element) {
2955+
elements_.remove(element);
2956+
sorted_ = elements_.size() < 2;
29562957
}
29572958
}
29582959
}

0 commit comments

Comments
 (0)