fix: double-transformed card appearing wrong in the opposing hand

beheh · beheh · commit 8f8c330545a3 · 2024-08-12T19:09:17.000+02:00
diff --git a/ts/protocol/HSReplayDecoder.ts b/ts/protocol/HSReplayDecoder.ts
@@ -479,8 +479,10 @@ export default class HSReplayDecoder extends Stream.Transform
 					cardId = "BOT_434"; // Flobbidinous Floop
 					break;
 				default:
-					// prefer reporting unknown card as opposed to transformed
-					return;
+					// explicitly flag as unknown, so they won't be overridden
+					// again later (e.g. on ChangeEntity)
+					cardId = undefined;
+					break;
 			}
 		}
 		const newCardIds = this.cardIds.set(id, cardId);

Original file line number	Diff line number	Diff line change
`@@ -479,8 +479,10 @@ export default class HSReplayDecoder extends Stream.Transform`
`479`	`479`	`cardId = "BOT_434"; // Flobbidinous Floop`
`480`	`480`	`break;`
`481`	`481`	`default:`
`482`		`- // prefer reporting unknown card as opposed to transformed`
`483`		`- return;`
	`482`	`+ // explicitly flag as unknown, so they won't be overridden`
	`483`	`+ // again later (e.g. on ChangeEntity)`
	`484`	`+ cardId = undefined;`
	`485`	`+ break;`
`484`	`486`	`}`
`485`	`487`	`}`
`486`	`488`	`const newCardIds = this.cardIds.set(id, cardId);`