Fix the order of args to Bbox

Hiromu Hota · Hiromu Hota · commit 18f8a59c3de9 · 2020-06-12T11:29:13.000-07:00
diff --git a/src/fonduer/parser/visual_linker.py b/src/fonduer/parser/visual_linker.py
@@ -161,7 +161,7 @@ def _coordinates_from_HTML(
                             word_id = (page_num, i)
                             pdf_word_list.append((word_id, content))
                             coordinate_map[word_id] = Bbox(
-                                page_num, y_min_line, xmin, y_max_line, xmax,
+                                page_num, y_min_line, y_max_line, xmin, xmax,
                             )
                             block_coordinates[word_id] = (y_min_block, x_min_block)
                             i += 1
diff --git a/src/fonduer/utils/visualizer.py b/src/fonduer/utils/visualizer.py
@@ -95,8 +95,8 @@ def display_words(
                         Bbox(
                             sentence.page[i],
                             sentence.top[i],
-                            sentence.left[i],
                             sentence.bottom[i],
+                            sentence.left[i],
                             sentence.right[i],
                         )
                     )
@@ -109,8 +109,8 @@ def get_box(span: SpanMention) -> Bbox:
     return Bbox(
         min(span.get_attrib_tokens("page")),
         min(span.get_attrib_tokens("top")),
-        min(span.get_attrib_tokens("left")),
         max(span.get_attrib_tokens("bottom")),
+        min(span.get_attrib_tokens("left")),
         max(span.get_attrib_tokens("right")),
     )
 

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ def _coordinates_from_HTML(`
`161`	`161`	`word_id = (page_num, i)`
`162`	`162`	`pdf_word_list.append((word_id, content))`
`163`	`163`	`coordinate_map[word_id] = Bbox(`
`164`		`- page_num, y_min_line, xmin, y_max_line, xmax,`
	`164`	`+ page_num, y_min_line, y_max_line, xmin, xmax,`
`165`	`165`	`)`
`166`	`166`	`block_coordinates[word_id] = (y_min_block, x_min_block)`
`167`	`167`	`i += 1`
Original file line number	Diff line number	Diff line change
`@@ -95,8 +95,8 @@ def display_words(`
`95`	`95`	`Bbox(`
`96`	`96`	`sentence.page[i],`
`97`	`97`	`sentence.top[i],`
`98`		`- sentence.left[i],`
`99`	`98`	`sentence.bottom[i],`
	`99`	`+ sentence.left[i],`
`100`	`100`	`sentence.right[i],`
`101`	`101`	`)`
`102`	`102`	`)`
`@@ -109,8 +109,8 @@ def get_box(span: SpanMention) -> Bbox:`
`109`	`109`	`return Bbox(`
`110`	`110`	`min(span.get_attrib_tokens("page")),`
`111`	`111`	`min(span.get_attrib_tokens("top")),`
`112`		`- min(span.get_attrib_tokens("left")),`
`113`	`112`	`max(span.get_attrib_tokens("bottom")),`
	`113`	`+ min(span.get_attrib_tokens("left")),`
`114`	`114`	`max(span.get_attrib_tokens("right")),`
`115`	`115`	`)`
`116`	`116`