FIX Replace new FieldsValidator with SimpleFieldsValidator #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1/replace-fieldsvalidator
branch
2 times, most recently
from
6e7a044 to
4d0aad4
Compare
We override some default stuff, so lets make sure we're not breaking anything in lieu of adding our own tests for now.
GuySartorelli
force-pushed
the
pulls/1/replace-fieldsvalidator
branch
from
4d0aad4 to
95e735c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures anyone checking for a
FieldsValidatorwill correctly fetch out theSimpleFieldsValidatorwhich does the same job, and it ensures that there is only one fields validator there, rather than having both the new defaultFieldsValidatorand ourSimpleFieldsValidatorwhich would duplicate effort.