feat: allow specifying hook command directory (#6982)

Author: gsquared94

docs/content/en/schemas/v2beta27.json

@@ -2091,6 +2091,11 @@
           "x-intellij-html-description": "command to execute.",
           "default": "[]"
         },
+        "dir": {
+          "type": "string",
+          "description": "specifies the working directory of the command. If empty, the command runs in the calling process's current directory.",
+          "x-intellij-html-description": "specifies the working directory of the command. If empty, the command runs in the calling process's current directory."
+        },
         "os": {
           "items": {
             "type": "string"
@@ -2103,7 +2108,8 @@
       },
       "preferredOrder": [
         "command",
-        "os"
+        "os",
+        "dir"
       ],
       "additionalProperties": false,
       "type": "object",

integration/examples/lifecycle-hooks/skaffold.yaml

@@ -7,8 +7,10 @@ build:
       before:
         - command: ["sh", "-c", "./hook.sh"]
           os: [darwin, linux]
+          dir: .
         - command: ["cmd.exe", "/C", "hook.bat"]
           os: [windows]
+          dir: .
       after:
         - command: ["sh", "-c", "docker images $SKAFFOLD_IMAGE --digests"]
           os: [darwin, linux]

pkg/skaffold/hooks/host.go

@@ -58,6 +58,7 @@ func (h hostHook) retrieveCmd(ctx context.Context, out io.Writer) *exec.Cmd {
 	cmd.Stderr = out
 	cmd.Env = append(cmd.Env, h.env...)
 	cmd.Env = append(cmd.Env, util.OSEnviron()...)
+	cmd.Dir = h.cfg.Dir
 
 	return cmd
 }

pkg/skaffold/schema/latest/v1/config.go

@@ -1465,6 +1465,9 @@ type HostHook struct {
 	Command []string `yaml:"command" yamltags:"required"`
 	// OS is an optional slice of operating system names. If the host machine OS is different, then it skips execution.
 	OS []string `yaml:"os,omitempty"`
+	// Dir specifies the working directory of the command.
+	// If empty, the command runs in the calling process's current directory.
+	Dir string `yaml:"dir,omitempty" skaffold:"filepath"`
 }
 
 // ContainerHook describes a lifecycle hook definition to execute on a container. The container name is inferred from the scope in which this hook is defined.