fix: remove io.Writer from stop method in exec env

Author: renzodavid9

pkg/skaffold/actions/docker/exec_env.go

@@ -130,7 +130,7 @@ func (e ExecEnv) Cleanup(ctx context.Context, out io.Writer) error {
 	return nil
 }
 
-func (e ExecEnv) Stop(out io.Writer) {
+func (e ExecEnv) Stop() {
 	e.logger.Stop() // Print the logs of the containers that were not able to print during execution.
 }
 

pkg/skaffold/actions/runner.go

@@ -104,7 +104,7 @@ func (r Runner) cleanup(ctx context.Context, out io.Writer, ts []Task, execEnvs
 	log.Entry(ctx).Debugf("Starting execution cleanup")
 
 	for _, execEnv := range execEnvs {
-		execEnv.Stop(out)
+		execEnv.Stop()
 	}
 
 	for _, t := range ts {

pkg/skaffold/actions/runner_test.go

@@ -60,7 +60,7 @@ func (me mockExecEnv) PrepareActions(ctx context.Context, out io.Writer, allbuil
 	return me.MockActions, nil
 }
 
-func (me mockExecEnv) Stop(out io.Writer) {}
+func (me mockExecEnv) Stop() {}
 
 func (me mockExecEnv) Cleanup(ctx context.Context, out io.Writer) error {
 	return nil

pkg/skaffold/actions/types.go

@@ -48,5 +48,5 @@ type ExecEnv interface {
 	Cleanup(ctx context.Context, out io.Writer) error
 
 	// Stop stops any ongoing task started in the execution env necessary to run the tasks.
-	Stop(out io.Writer)
+	Stop()
 }