chore: remove kaniko NoPush field from skaffold schemas as it does not work currently

Author: aaron-prindle

docs-v2/content/en/schemas/v4beta4.json

@@ -2538,12 +2538,6 @@
           "x-intellij-html-description": "to add timestamps to log format.",
           "default": "false"
         },
-        "noPush": {
-          "type": "boolean",
-          "description": "if you only want to build the image, without pushing to a registry.",
-          "x-intellij-html-description": "if you only want to build the image, without pushing to a registry.",
-          "default": "false"
-        },
         "ociLayoutPath": {
           "type": "string",
           "description": "to specify a directory in the container where the OCI image layout of a built image will be placed. This can be used to automatically track the exact image built by kaniko.",
@@ -2651,7 +2645,6 @@
         "cleanup",
         "insecure",
         "insecurePull",
-        "noPush",
         "force",
         "logTimestamp",
         "reproducible",

pkg/skaffold/build/gcb/kaniko_test.go

@@ -194,16 +194,6 @@ func TestKanikoBuildSpec(t *testing.T) {
 				kaniko.LogTimestampFlag,
 			},
 		},
-		{
-			description: "with NoPush",
-			artifact: &latest.KanikoArtifact{
-				DockerfilePath: "Dockerfile",
-				NoPush:         true,
-			},
-			expectedArgs: []string{
-				kaniko.NoPushFlag,
-			},
-		},
 		{
 			description: "with OCILayoutPath",
 			artifact: &latest.KanikoArtifact{

pkg/skaffold/build/kaniko/args.go

@@ -101,10 +101,6 @@ func Args(artifact *latest.KanikoArtifact, tag, context string) ([]string, error
 		args = append(args, LogTimestampFlag)
 	}
 
-	if artifact.NoPush {
-		args = append(args, NoPushFlag)
-	}
-
 	if artifact.OCILayoutPath != "" {
 		args = append(args, OCILayoutFlag, artifact.OCILayoutPath)
 	}

pkg/skaffold/build/kaniko/args_test.go

@@ -187,17 +187,6 @@ func TestArgs(t *testing.T) {
 			},
 			wantErr: false,
 		},
-		{
-			description: "with NoPush",
-			artifact: &latest.KanikoArtifact{
-				DockerfilePath: "dir/Dockerfile",
-				NoPush:         true,
-			},
-			expectedArgs: []string{
-				NoPushFlag,
-			},
-			wantErr: false,
-		},
 		{
 			description: "with OCILayoutPath",
 			artifact: &latest.KanikoArtifact{

pkg/skaffold/build/kaniko/types.go

@@ -53,8 +53,6 @@ const (
 	LogFormatFlag = "--log-format"
 	// LogTimestampFlag additional flag
 	LogTimestampFlag = "--log-timestamp"
-	// NoPushFlag additional flag
-	NoPushFlag = "--no-push"
 	// OCILayoutFlag additional flag
 	OCILayoutFlag = "--oci-layout-path"
 	// RegistryCertificateFlag additional flag

pkg/skaffold/schema/latest/config.go

@@ -1344,9 +1344,6 @@ type KanikoArtifact struct {
 	// InsecurePull if you want to pull images from a plain HTTP registry.
 	InsecurePull bool `yaml:"insecurePull,omitempty"`
 
-	// NoPush if you only want to build the image, without pushing to a registry.
-	NoPush bool `yaml:"noPush,omitempty"`
-
 	// Force building outside of a container.
 	Force bool `yaml:"force,omitempty"`