Skip to content

Commit 109fe4e

Browse files
authored
chore: upgrade docker and make integration-in-docker to use docker dependencies from pr (#8596)
* chore: upgrade docker and make test-in-docker to use pr dependency * chore: fix docker build commandE * chore: fix docker build command
1 parent f412066 commit 109fe4e

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

Makefile

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,18 @@ build_deps:
210210
deploy/skaffold
211211
docker push gcr.io/$(GCP_PROJECT)/build_deps:$(DEPS_DIGEST)
212212

213+
skaffold-builder-ci:
214+
docker build \
215+
--cache-from gcr.io/$(GCP_PROJECT)/build_deps \
216+
-f deploy/skaffold/Dockerfile.deps \
217+
-t gcr.io/$(GCP_PROJECT)/build_deps \
218+
.
219+
time docker build \
220+
-f deploy/skaffold/Dockerfile \
221+
--target builder \
222+
-t gcr.io/$(GCP_PROJECT)/skaffold-builder \
223+
.
224+
213225
.PHONY: skaffold-builder
214226
skaffold-builder:
215227
time docker build \
@@ -272,7 +284,7 @@ integration-in-k3d: skaffold-builder
272284
'
273285

274286
.PHONY: integration-in-docker
275-
integration-in-docker: skaffold-builder
287+
integration-in-docker: skaffold-builder-ci
276288
docker run --rm \
277289
-v /var/run/docker.sock:/var/run/docker.sock \
278290
-v $(HOME)/.config/gcloud:/root/.config/gcloud \

deploy/skaffold/Dockerfile.deps

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,9 @@ RUN apt-get update && \
122122
git python unzip && \
123123
rm -rf /var/lib/apt/lists/*
124124

125-
COPY --from=docker:19.03.13 /usr/local/bin/docker /usr/local/bin/
125+
COPY --from=docker:23.0.1 /usr/local/bin/docker /usr/local/bin/
126+
# From Docker Engine version 23.0.0, Buildx is distributed in a separate package: docker-buildx-plugin. In earlier versions, Buildx was included in the docker-ce-cli package
127+
COPY --from=docker/buildx-bin:0.10.4 /buildx /usr/libexec/docker/cli-plugins/docker-buildx
126128
COPY --from=download-kubectl kubectl /usr/local/bin/
127129
COPY --from=download-helm helm /usr/local/bin/
128130
COPY --from=download-kustomize kustomize /usr/local/bin/

0 commit comments

Comments
 (0)