Set tab index onChange

mofiebiger · mofiebiger · commit cfaf9a7bc0c9 · 2022-05-13T16:24:00.000+01:00
diff --git a/addon/components/radio-group.js b/addon/components/radio-group.js
@@ -173,9 +173,10 @@ export default class RadioGroupComponent extends Component {
 
   _setActiveOption(option) {
     if (option) {
+      option.element.focus();
       this.activeOption = option;
       this.activeValue = option.value;
-      option.element.focus();
+      this.setTabIndex();
       this.onChange(option.value);
     }
   }
diff --git a/addon/components/radio-group/-option.hbs b/addon/components/radio-group/-option.hbs
@@ -1,4 +1,3 @@
-{{! template-lint-disable no-positive-tabindex}}
 <div
   id={{this.id}}
   ariaLabel={{@value}}
@@ -13,5 +12,4 @@
   ...attributes
 >
   {{yield}}
-</div>
-{{! template-lint-enable no-positive-tabindex}}
+</div>

Original file line number	Diff line number	Diff line change
`@@ -173,9 +173,10 @@ export default class RadioGroupComponent extends Component {`
`173`	`173`
`174`	`174`	`_setActiveOption(option) {`
`175`	`175`	`if (option) {`
	`176`	`+ option.element.focus();`
`176`	`177`	`this.activeOption = option;`
`177`	`178`	`this.activeValue = option.value;`
`178`		`- option.element.focus();`
	`179`	`+ this.setTabIndex();`
`179`	`180`	`this.onChange(option.value);`
`180`	`181`	`}`
`181`	`182`	`}`