Skip to content

Commit 7f0ff1e

Browse files
committed
add more request log
1 parent 5ede28f commit 7f0ff1e

File tree

2 files changed

+24
-8
lines changed

2 files changed

+24
-8
lines changed

gcoreprovider/gcore.go

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func (p *DnsProvider) ApplyChanges(rootCtx context.Context, changes *plan.Change
9797
if !changes.HasChanges() {
9898
return nil
9999
}
100-
log.Infof("%s: starting apply changes createLen=%d, deleteLen=%d, updateOldLen=%d, updateNewLen=%d",
100+
log.Infof("%s: ApplyChanges createLen=%d, deleteLen=%d, updateOldLen=%d, updateNewLen=%d",
101101
ProviderName, len(changes.Create), len(changes.Delete), len(changes.UpdateOld), len(changes.UpdateNew))
102102
ctx, cancel := p.ctxWithMyTimeout(rootCtx)
103103
defer cancel()
@@ -135,8 +135,11 @@ func (p *DnsProvider) ApplyChanges(rootCtx context.Context, changes *plan.Change
135135
continue
136136
}
137137
gr2.Go(func() error {
138-
return errSafeWrap(strings.Join(errMsg, "; "),
138+
err := errSafeWrap(strings.Join(errMsg, "; "),
139139
p.client.DeleteRRSetRecord(ctx, zone, d.DNSName, d.RecordType, recordValues...))
140+
log.Debugf("%s ApplyChanges.updateNew,DeleteRRSetRecord: %s %s %v ERR=%s",
141+
ProviderName, d.DNSName, d.RecordType, recordValues, err)
142+
return err
140143
})
141144
}
142145
// remove deleted records
@@ -161,8 +164,11 @@ func (p *DnsProvider) ApplyChanges(rootCtx context.Context, changes *plan.Change
161164
errMsg = append(errMsg, msg)
162165
}
163166
gr1.Go(func() error {
164-
return errSafeWrap(strings.Join(errMsg, "; "),
167+
err := errSafeWrap(strings.Join(errMsg, "; "),
165168
p.client.DeleteRRSetRecord(ctx, zone, d.DNSName, d.RecordType, recordValues...))
169+
log.Debugf("%s ApplyChanges.Delete,DeleteRRSetRecord: %s %s %v ERR=%s",
170+
ProviderName, d.DNSName, d.RecordType, recordValues, err)
171+
return err
166172
})
167173
}
168174
// add created records
@@ -187,8 +193,11 @@ func (p *DnsProvider) ApplyChanges(rootCtx context.Context, changes *plan.Change
187193
errMsg = append(errMsg, msg)
188194
}
189195
gr1.Go(func() error {
190-
return errSafeWrap(strings.Join(errMsg, "; "),
196+
err := errSafeWrap(strings.Join(errMsg, "; "),
191197
p.client.AddZoneRRSet(ctx, zone, c.DNSName, c.RecordType, recordValues, int(c.RecordTTL)))
198+
log.Debugf("%s ApplyChanges.Create,AddZoneRRSet: %s %s %v ERR=%s",
199+
ProviderName, c.DNSName, c.RecordType, recordValues, err)
200+
return err
192201
})
193202
}
194203
// wait preparing before send updates to records
@@ -222,8 +231,11 @@ func (p *DnsProvider) ApplyChanges(rootCtx context.Context, changes *plan.Change
222231
continue
223232
}
224233
gr1.Go(func() error {
225-
return errSafeWrap(strings.Join(errMsg, "; "),
234+
err := errSafeWrap(strings.Join(errMsg, "; "),
226235
p.client.AddZoneRRSet(ctx, zone, c.DNSName, c.RecordType, recordValues, int(c.RecordTTL)))
236+
log.Debugf("%s ApplyChanges.UpdateNew,AddZoneRRSet: %s %s %v ERR=%s",
237+
ProviderName, c.DNSName, c.RecordType, recordValues)
238+
return err
227239
})
228240
}
229241
err = gr1.Wait()
@@ -236,17 +248,17 @@ func (p *DnsProvider) ApplyChanges(rootCtx context.Context, changes *plan.Change
236248
}
237249

238250
func (p *DnsProvider) GetDomainFilter() endpoint.DomainFilter {
239-
log.Debugf("%s: starting get domain filters", ProviderName)
251+
log.Debugf("%s: GetDomainFilter", ProviderName)
240252
zs, err := p.client.ZonesWithRecords(context.Background())
241253
if err != nil {
242-
log.Errorf("%s: get domain filters: %v", ProviderName, err)
254+
log.Errorf("%s: ERROR GetDomainFilter: %v", ProviderName, err)
243255
return endpoint.DomainFilter{}
244256
}
245257
domains := make([]string, 0)
246258
for _, z := range zs {
247259
domains = append(domains, z.Name, "."+z.Name)
248260
}
249-
defer log.Debugf("%s: finishing get domain filters with %+v", ProviderName, domains)
261+
defer log.Debugf("%s: GetDomainFilter: %+v", ProviderName, domains)
250262
return endpoint.NewDomainFilter(domains)
251263
}
252264

main.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ func CreateWebServer(p *gcoreprovider.DnsProvider) *webServer {
8989
w.WriteHeader(http.StatusOK)
9090
})
9191
r.Get("/", func(w http.ResponseWriter, r *http.Request) { // negotiate
92+
requestLog(r).Debug("GET /")
9293
if err := acceptHeaderCheck(w, r); err != nil {
9394
requestLog(r).WithField(logFieldError, err).Error("accept header check failed")
9495
return
@@ -107,6 +108,7 @@ func CreateWebServer(p *gcoreprovider.DnsProvider) *webServer {
107108
}
108109
})
109110
r.Get("/records", func(w http.ResponseWriter, r *http.Request) {
111+
requestLog(r).Debug("GET /records")
110112
if err := acceptHeaderCheck(w, r); err != nil {
111113
requestLog(r).WithField(logFieldError, err).Error("accept header check failed")
112114
return
@@ -133,6 +135,7 @@ func CreateWebServer(p *gcoreprovider.DnsProvider) *webServer {
133135
}
134136
})
135137
r.Post("/records", func(w http.ResponseWriter, r *http.Request) {
138+
requestLog(r).Debug("POST /")
136139
if err := contentTypeHeaderCheck(w, r); err != nil {
137140
requestLog(r).WithField(logFieldError, err).Error("content type header check failed")
138141
return
@@ -171,6 +174,7 @@ func CreateWebServer(p *gcoreprovider.DnsProvider) *webServer {
171174
w.WriteHeader(http.StatusNoContent)
172175
})
173176
r.Post("/adjustendpoints", func(w http.ResponseWriter, r *http.Request) {
177+
requestLog(r).Debug("POST /adjustendpoints")
174178
if err := contentTypeHeaderCheck(w, r); err != nil {
175179
log.Errorf("content type header check failed, request method: %s, request path: %s", r.Method, r.URL.Path)
176180
return

0 commit comments

Comments
 (0)