Skip to content

Commit c8af953

Browse files
dmaichertobias-93
authored andcommitted
add Support for Symfony 8
1 parent b95b845 commit c8af953

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

.github/workflows/code_checks.yaml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,11 @@ jobs:
5757

5858
- php: '8.2'
5959
dependencies: highest
60-
symfony: '7.0.*'
60+
symfony: '7.3.*'
61+
62+
- php: '8.4'
63+
dependencies: highest
64+
symfony: '8.0.*'
6165
steps:
6266
- name: Checkout
6367
uses: actions/checkout@v5
@@ -67,6 +71,11 @@ jobs:
6771
with:
6872
php-version: ${{ matrix.php }}
6973

74+
# until its released
75+
- name: Use dev stability for Symfony 8
76+
if: matrix.symfony == '8.0.*'
77+
run: composer config minimum-stability dev
78+
7079
- name: Require Symfony version
7180
if: matrix.symfony != '*'
7281
run: |

Tests/Command/RouterDebugExposedCommandTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,10 @@ public function testExecute(): void
5353
$tester = new CommandTester($command);
5454
$tester->execute([]);
5555

56-
$this->assertMatchesRegularExpression('/literal(.*ANY){3}.*\/literal/', $tester->getDisplay());
57-
$this->assertMatchesRegularExpression('/blog_post(.*ANY){3}.*\/blog-post\/{slug}/', $tester->getDisplay());
58-
$this->assertMatchesRegularExpression('/list(.*ANY){3}.*\/literal/', $tester->getDisplay());
56+
// with Symfony 8 Scheme and Host columns are conditionally shown
57+
$this->assertMatchesRegularExpression('/literal(.*ANY){1,3}.*\/literal/', $tester->getDisplay());
58+
$this->assertMatchesRegularExpression('/blog_post(.*ANY){1,3}.*\/blog-post\/{slug}/', $tester->getDisplay());
59+
$this->assertMatchesRegularExpression('/list(.*ANY){1,3}.*\/literal/', $tester->getDisplay());
5960
}
6061

6162
public function testExecuteWithNameUnknown(): void

composer.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@
1717
],
1818
"require": {
1919
"php": "^8.0",
20-
"symfony/console": "^5.4|^6.4|^7.0",
20+
"symfony/console": "^5.4|^6.4|^7.3|^8.0",
2121
"symfony/deprecation-contracts": "^2.1|^3.0",
22-
"symfony/framework-bundle": "^5.4|^6.4|^7.0",
23-
"symfony/serializer": "^5.4|^6.4|^7.0",
22+
"symfony/framework-bundle": "^5.4|^6.4|^7.3|^8.0",
23+
"symfony/serializer": "^5.4|^6.4|^7.3|^8.0",
2424
"willdurand/jsonp-callback-validator": "~1.1|^2.0"
2525
},
2626
"require-dev": {
2727
"neronmoon/scriptsdev": "^0.1",
2828
"jakoch/phantomjs-installer": "^3",
29-
"symfony/expression-language": "^5.4|^6.4|^7.0",
30-
"symfony/phpunit-bridge": "^5.4|^6.4|^7.0"
29+
"symfony/expression-language": "^5.4|^6.4|^7.3|^8.0",
30+
"symfony/phpunit-bridge": "^7.3|^8.0"
3131
},
3232
"autoload": {
3333
"psr-4": { "FOS\\JsRoutingBundle\\": "" },

0 commit comments

Comments
 (0)