fix: handle different Browser Revisions

Author: Flayms

Markdown2Pdf.Tests/Tests/Utils.cs

@@ -1,5 +1,6 @@
 using System.Text.RegularExpressions;
 using PuppeteerSharp;
+using PuppeteerSharp.BrowserData;
 using UglyToad.PdfPig;
 using UglyToad.PdfPig.DocumentLayoutAnalysis.TextExtractor;
 
@@ -27,15 +28,22 @@ internal static async Task<string> RenderHtmlAsync(string htmlFilePath) {
   private static async Task<IBrowser> _CreateBrowserAsync() {
     var launchOptions = new LaunchOptions {
       Headless = true,
-      Args = ["--no-sandbox"],
+      Args = ["--no-sandbox"], // needed for running inside docker
     };
 
     var browserFetcher = new BrowserFetcher();
     var installed = browserFetcher.GetInstalledBrowsers();
+    var hasDefaultRevisionInstalled = installed.Any(installedBrowser => installedBrowser.BuildId == Chrome.DefaultBuildId);
 
-    if (!installed.Any()) {
-      Console.WriteLine("Downloading chromium...");
-      _ = await browserFetcher.DownloadAsync();
+    if (!hasDefaultRevisionInstalled) {
+      // Uninstall old revisions
+      foreach (var oldBrowser in installed) {
+        Console.WriteLine($"Uninstalling old Chrome version {oldBrowser.BuildId} from {browserFetcher.CacheDir}...");
+        browserFetcher.Uninstall(oldBrowser.BuildId);
+      }
+
+      Console.WriteLine($"Path to Chrome was not specified & default build is not installed. Downloading Chrome version {Chrome.DefaultBuildId} to {browserFetcher.CacheDir}...");
+      _ = await browserFetcher.DownloadAsync(Chrome.DefaultBuildId);
     }
 
     return await Puppeteer.LaunchAsync(launchOptions);

Markdown2Pdf/Markdown2Pdf.csproj

@@ -62,7 +62,7 @@
 	<ItemGroup>
 		<PackageReference Include="Markdig" Version="0.36.2" />
 		<PackageReference Include="PdfPig" Version="0.1.8" />
-		<PackageReference Include="PuppeteerSharp" Version="18.0.0" />
+		<PackageReference Include="PuppeteerSharp" Version="20.1.3" />
 		<PackageReference Include="YamlDotNet" Version="15.1.2" />
 	</ItemGroup>
 

Markdown2Pdf/Markdown2PdfConverter.cs

@@ -10,6 +10,7 @@
 using Markdown2Pdf.Options;
 using Markdown2Pdf.Services;
 using PuppeteerSharp;
+using PuppeteerSharp.BrowserData;
 using PuppeteerSharp.Media;
 
 namespace Markdown2Pdf;
@@ -419,10 +420,17 @@ private async Task<IBrowser> _CreateBrowserAsync() {
 
     var browserFetcher = new BrowserFetcher();
     var installed = browserFetcher.GetInstalledBrowsers();
+    var hasDefaultRevisionInstalled = installed.Any(installedBrowser => installedBrowser.BuildId == Chrome.DefaultBuildId);
 
-    if (!installed.Any()) {
-      Console.WriteLine("Path to chrome was not specified. Downloading chrome...");
-      _ = await browserFetcher.DownloadAsync();
+    if (!hasDefaultRevisionInstalled) {
+      // Uninstall old revisions
+      foreach (var oldBrowser in installed) {
+        Console.WriteLine($"Uninstalling old Chrome version {oldBrowser.BuildId} from {browserFetcher.CacheDir}...");
+        browserFetcher.Uninstall(oldBrowser.BuildId);
+      }
+
+      Console.WriteLine($"Path to Chrome was not specified & default build is not installed. Downloading Chrome version {Chrome.DefaultBuildId} to {browserFetcher.CacheDir}...");
+      _ = await browserFetcher.DownloadAsync(Chrome.DefaultBuildId);
     }
 
     return await Puppeteer.LaunchAsync(launchOptions);