Skip to content

Commit f1577fc

Browse files
committed
Revert merge pull requests
Revert commits: 368bbf4 069f03b 2445742 d4cb0ac d56f7ec
1 parent 368bbf4 commit f1577fc

File tree

2 files changed

+6
-58
lines changed

2 files changed

+6
-58
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ You can specify the following options using the ["with" syntax](https://docs.git
6969
- description: 'Version of Firely Terminal used for .NET-based validation'
7070
- default: '3.3.2'
7171
- required: true
72-
* FIRELY_TERMINAL_VALIDATOR_ENGINE:
73-
- description: 'Firely Terminal validator engine to use for .NET validation. Available options: Regular, Advanced'
74-
- default: 'Advanced'
75-
- required: false
7672
* JAVA_VALIDATOR_VERSION:
7773
- description: 'Version of org.hl7.fhir.core library used for Java-based validation'
7874
- default: '6.5.2'

action.yml

Lines changed: 6 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ inputs:
6262
description: 'Enables creating snapshots for the package dependencies using the Java validator. Snapshots created by Firely Terminal will be disregarded. Does not yet work together with the ZTS_ENABLED setting.'
6363
default: false
6464
required: false
65-
FIRELY_TERMINAL_VALIDATOR_ENGINE:
66-
description: 'Firely Terminal validator engine to use for .NET validation. Available options: Regular, Advanced'
67-
default: 'Regular'
68-
required: false
6965

7066
# Validate all resources using Firely Terminal
7167
runs:
@@ -144,10 +140,10 @@ runs:
144140
INPUT_SIMPLIFIER_USERNAME: ${{ inputs.SIMPLIFIER_USERNAME }}
145141
INPUT_SIMPLIFIER_PASSWORD: ${{ inputs.SIMPLIFIER_PASSWORD }}
146142

147-
# Detect FHIR version from package.json
148-
- name: Detect FHIR version
143+
# Restore all dependencies listed in the package.json file (need to be on the root level)
144+
- name: FHIR Dependency restore
149145
run: |
150-
if $INPUT_DOTNET_VALIDATION_ENABLED || $INPUT_SUSHI_ENABLED || $INPUT_JAVA_VALIDATION_ENABLED; then
146+
if $INPUT_DOTNET_VALIDATION_ENABLED || $INPUT_SUSHI_ENABLED; then
151147
if [ ! -f "package.json" ]; then
152148
echo "package.json does not exist. Please add it to the root folder and add all project dependencies."
153149
exit 1
@@ -162,36 +158,6 @@ runs:
162158
fi
163159
done
164160
165-
if [[ -z "$fhirVersion" ]]; then
166-
echo "No supported FHIR version (3.0.2, 4.0.1, 4.1.0, 4.6.0) was found in package.json (.fhirVersions)"
167-
exit 1
168-
fi
169-
echo "Detected FHIR version: $fhirVersion"
170-
echo "FHIR_VERSION=$fhirVersion" >> "$GITHUB_ENV"
171-
fi
172-
shell: bash
173-
env:
174-
INPUT_DOTNET_VALIDATION_ENABLED: ${{ inputs.DOTNET_VALIDATION_ENABLED }}
175-
INPUT_SUSHI_ENABLED: ${{ inputs.SUSHI_ENABLED }}
176-
INPUT_JAVA_VALIDATION_ENABLED: ${{ inputs.JAVA_VALIDATION_ENABLED }}
177-
178-
# Set Firely Terminal FHIR specification and restore dependencies
179-
- name: Set FHIR specification and restore dependencies
180-
run: |
181-
if $INPUT_DOTNET_VALIDATION_ENABLED || $INPUT_SUSHI_ENABLED || $INPUT_JAVA_VALIDATION_ENABLED; then
182-
if [[ "$FHIR_VERSION" = "3.0.2" ]]; then
183-
fhir spec R3
184-
elif [[ "$FHIR_VERSION" = "4.0.1" ]]; then
185-
fhir spec R4
186-
elif [[ "$FHIR_VERSION" = "4.1.0" ]]; then
187-
fhir spec R4B
188-
elif [[ "$FHIR_VERSION" = "4.6.0" ]]; then
189-
fhir spec R5
190-
else
191-
echo "This FHIR version is currently not supported."
192-
exit 1
193-
fi
194-
195161
echo "Attempting to restore package dependencies based on package.json ..."
196162
fhir config regenerate on
197163
FHIR_RESTORE=$((fhir restore | tr '\n' ' ')|| true) # Print everything in a single line
@@ -205,8 +171,6 @@ runs:
205171
env:
206172
INPUT_DOTNET_VALIDATION_ENABLED: ${{ inputs.DOTNET_VALIDATION_ENABLED }}
207173
INPUT_SUSHI_ENABLED: ${{ inputs.SUSHI_ENABLED }}
208-
FHIR_VERSION: ${{ env.FHIR_VERSION }}
209-
210174

211175
# ZTS (Central Terminology Server for Germany, terminologien.bfarm.de) package loading
212176
- name: ZTS Package dependency restore
@@ -350,19 +314,7 @@ runs:
350314
# --------------------------------------------------------------------------------------------------- #
351315
# .NET VALIDATOR #
352316
# --------------------------------------------------------------------------------------------------- #
353-
354-
# Set Firely Terminal validator engine
355-
- name: Configure Firely Terminal validator engine
356-
run: |
357-
if $INPUT_DOTNET_VALIDATION_ENABLED; then
358-
echo "Setting Firely Terminal validator engine to: $FIRELY_TERMINAL_VALIDATOR_ENGINE"
359-
fhir config validator $FIRELY_TERMINAL_VALIDATOR_ENGINE
360-
fi
361-
shell: bash
362-
env:
363-
INPUT_DOTNET_VALIDATION_ENABLED: ${{ inputs.DOTNET_VALIDATION_ENABLED }}
364-
FIRELY_TERMINAL_VALIDATOR_ENGINE: ${{ inputs.FIRELY_TERMINAL_VALIDATOR_ENGINE }}
365-
317+
366318
# Run Quality Control checks incl. validation
367319
- name: Run Quality Control checks
368320
run: |
@@ -497,7 +449,7 @@ runs:
497449
echo "Finished validation using Java validator (Conformance resources) ..."
498450
shell: bash
499451
env:
500-
FHIR_VERSION: ${{ env.FHIR_VERSION }}
452+
FHIR_VERSION: "4.0"
501453
INPUT_PATH_TO_CONFORMANCE_RESOURCES: ${{ inputs.PATH_TO_CONFORMANCE_RESOURCES }}
502454
INPUT_JAVA_VALIDATION_ENABLED: ${{ inputs.JAVA_VALIDATION_ENABLED }}
503455
INPUT_EXPECTED_FAILS: ${{ inputs.EXPECTED_FAILS }}
@@ -548,9 +500,9 @@ runs:
548500
fi
549501
shell: bash
550502
env:
551-
FHIR_VERSION: ${{ env.FHIR_VERSION }}
552503
INPUT_PATH_TO_CONFORMANCE_RESOURCES: ${{ inputs.PATH_TO_CONFORMANCE_RESOURCES }}
553504
PATH_TO_EXAMPLES: ${{ inputs.PATH_TO_EXAMPLES }}
505+
FHIR_VERSION: "4.0"
554506
INPUT_JAVA_VALIDATION_ENABLED: ${{ inputs.JAVA_VALIDATION_ENABLED }}
555507
INPUT_EXPECTED_FAILS: ${{ inputs.EXPECTED_FAILS }}
556508
INPUT_JAVA_VALIDATION_OPTIONS: ${{ inputs.JAVA_VALIDATION_OPTIONS }}

0 commit comments

Comments
 (0)