Merge pull request #220 from EvotecIT/update-downloadasync-to-check-directory-presence

Author: PrzemyslawKlys

SectigoCertificateManager.Tests/CertificatesClientTests.cs

@@ -412,6 +412,38 @@ public async Task DownloadAsync_WritesFile(int certificateId, bool isValid) {
         }
     }
 
+    [Fact]
+    public async Task DownloadAsync_WritesFileToWorkingDirectory() {
+        var response = new HttpResponseMessage(HttpStatusCode.OK) {
+            Content = new StringContent("DATA")
+        };
+
+        var handler = new TestHandler(response);
+        using var httpClient = new HttpClient(handler);
+        var client = new SectigoClient(new ApiConfig("https://example.com/", "u", "p", "c", ApiVersion.V25_4), httpClient);
+        var certificates = new CertificatesClient(client);
+
+        var dir = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
+        Directory.CreateDirectory(dir);
+        var originalDir = Directory.GetCurrentDirectory();
+        Directory.SetCurrentDirectory(dir);
+        var fileName = Path.GetRandomFileName();
+        try {
+            await certificates.DownloadAsync(1, fileName);
+            Assert.NotNull(handler.Request);
+            Assert.Equal("https://example.com/ssl/v1/collect/1?format=base64", handler.Request!.RequestUri!.ToString());
+            var fullPath = Path.Combine(dir, fileName);
+            Assert.True(File.Exists(fullPath));
+            Assert.Equal("DATA", File.ReadAllText(fullPath));
+            Assert.Empty(Directory.GetDirectories(dir));
+        } finally {
+            Directory.SetCurrentDirectory(originalDir);
+            if (Directory.Exists(dir)) {
+                Directory.Delete(dir, true);
+            }
+        }
+    }
+
     [Theory]
     [InlineData("")]
     [InlineData(null)]

SectigoCertificateManager/Clients/CertificatesClient.Download.cs

@@ -103,7 +103,10 @@ public async Task DownloadAsync(
         var response = await _client.GetAsync(url, cancellationToken).ConfigureAwait(false);
         var stream = await response.Content.ReadAsStreamAsync().ConfigureAwait(false);
         using (stream) {
-            Directory.CreateDirectory(Path.GetDirectoryName(path)!);
+            var directory = Path.GetDirectoryName(path);
+            if (!string.IsNullOrEmpty(directory)) {
+                Directory.CreateDirectory(directory);
+            }
             using var file = new FileStream(path, FileMode.Create, FileAccess.Write, FileShare.None);
             var buffer = new byte[65536];
             long total = response.Content.Headers.ContentLength ?? (stream.CanSeek ? stream.Length : -1);