fix(requests): 🐛 throw on unreadable CSR stream

Author: PrzemyslawKlys

SectigoCertificateManager.Tests/RenewCertificateRequestTests.cs

@@ -16,6 +16,10 @@ private sealed class TestProgress : IProgress<double> {
         public void Report(double value) => Value = value;
     }
 
+    private sealed class UnreadableStream : MemoryStream {
+        public override bool CanRead => false;
+    }
+
     /// <summary>Reads CSR from a stream.</summary>
     [Fact]
     public void SetCsr_FromStream_SetsProperty() {
@@ -51,4 +55,12 @@ public void SetCsr_SeeksToBeginning() {
 
         Assert.Equal(Base64Csr, request.Csr);
     }
+
+    [Fact]
+    public void SetCsr_UnreadableStream_Throws() {
+        using var stream = new UnreadableStream();
+        var request = new RenewCertificateRequest();
+
+        Assert.Throws<ArgumentException>(() => request.SetCsr(stream));
+    }
 }

SectigoCertificateManager/Requests/RenewCertificateRequest.cs

@@ -26,6 +26,10 @@ public sealed class RenewCertificateRequest {
     public void SetCsr(Stream stream, IProgress<double>? progress = null) {
         Guard.AgainstNull(stream, nameof(stream));
 
+        if (!stream.CanRead) {
+            throw new ArgumentException("Stream must be readable.", nameof(stream));
+        }
+
         if (stream.CanSeek) {
             stream.Seek(0, SeekOrigin.Begin);
         }