Skip to content

Commit 795eab3

Browse files
justinhorvitzcopybara-github
authored andcommitted
Fix crash with --experimental_skyframe_prepare_analysis by accepting any DetailedException.
It is possible to get a `MissingInputFileException` if the file specified by `--platform_mappings` does not exist. We apparently don't have any tests for `--experimental_skyframe_prepare_analysis`. PiperOrigin-RevId: 414681532
1 parent f4db9ce commit 795eab3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3037,8 +3037,8 @@ public PrepareAnalysisPhaseValue prepareAnalysisPhase(
30373037
e =
30383038
new InvalidConfigurationException(
30393039
"cannot load build configuration because of this cycle", Code.CYCLE);
3040-
} else if (e instanceof NoSuchThingException) {
3041-
e = new InvalidConfigurationException(((NoSuchThingException) e).getDetailedExitCode(), e);
3040+
} else if (e instanceof DetailedException) {
3041+
e = new InvalidConfigurationException(((DetailedException) e).getDetailedExitCode(), e);
30423042
}
30433043
if (e != null) {
30443044
Throwables.throwIfInstanceOf(e, InvalidConfigurationException.class);

0 commit comments

Comments
 (0)