Skip to content

Commit 748b996

Browse files
hvadehracopybara-github
authored andcommitted
Fix java_common.target_kind when aspects are involved
PiperOrigin-RevId: 412242583
1 parent 0a93c1f commit 748b996

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/main/java/com/google/devtools/build/lib/analysis/configuredtargets/MergedConfiguredTarget.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ public Dict<String, Object> getProvidersDict() {
273273
}
274274

275275
@VisibleForTesting
276-
public ConfiguredTarget getBaseConfiguredTargetForTesting() {
276+
public ConfiguredTarget getBaseConfiguredTarget() {
277277
return base;
278278
}
279279
}

src/main/java/com/google/devtools/build/lib/rules/java/JavaStarlarkCommon.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import com.google.common.collect.ImmutableSet;
2121
import com.google.devtools.build.lib.actions.Artifact;
2222
import com.google.devtools.build.lib.analysis.configuredtargets.AbstractConfiguredTarget;
23+
import com.google.devtools.build.lib.analysis.configuredtargets.MergedConfiguredTarget;
2324
import com.google.devtools.build.lib.analysis.platform.ConstraintValueInfo;
2425
import com.google.devtools.build.lib.analysis.starlark.StarlarkActionFactory;
2526
import com.google.devtools.build.lib.analysis.starlark.StarlarkRuleContext;
@@ -297,6 +298,9 @@ public ProviderApi getBootClassPathInfo() {
297298
@Override
298299
public String getTargetKind(Object target, StarlarkThread thread) throws EvalException {
299300
checkPrivateAccess(thread);
301+
if (target instanceof MergedConfiguredTarget) {
302+
target = ((MergedConfiguredTarget) target).getBaseConfiguredTarget();
303+
}
300304
if (target instanceof AbstractConfiguredTarget) {
301305
return ((AbstractConfiguredTarget) target).getRuleClassString();
302306
}

0 commit comments

Comments
 (0)