Skip to content

Commit 368fcf7

Browse files
Googlercopybara-github
authored andcommitted
Automatic code cleanup.
PiperOrigin-RevId: 425873532
1 parent 3f666c7 commit 368fcf7

25 files changed

+51
-46
lines changed

src/main/java/com/google/devtools/build/lib/rules/android/AndroidIdeInfoProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ public ImmutableMap<String, Depset> getNativeLibsStarlark() {
310310
for (Map.Entry<String, NestedSet<Artifact>> entry : getNativeLibs().entrySet()) {
311311
builder.put(entry.getKey(), Depset.of(Artifact.TYPE, entry.getValue()));
312312
}
313-
return builder.build();
313+
return builder.buildOrThrow();
314314
}
315315

316316
/** Provider class for {@link AndroidIdeInfoProvider} objects. */
@@ -360,7 +360,7 @@ public AndroidIdeInfoProvider createInfo(
360360
ImmutableList.copyOf(
361361
Sequence.cast(idlGeneratedJavaFiles, Artifact.class, "idl_generated_java_files")),
362362
ImmutableList.copyOf(Sequence.cast(apksUnderTest, Artifact.class, "apks_under_test")),
363-
builder.build(),
363+
builder.buildOrThrow(),
364364
fromNoneable(resourceApk, Artifact.class));
365365
}
366366
}

src/main/java/com/google/devtools/build/lib/rules/android/AndroidIdlHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ private static ImmutableMap<Artifact, Artifact> generateTranslatedIdlArtifacts(
272272
Artifact output = ruleContext.getGenfilesArtifact(javaOutputPath.getPathString());
273273
outputJavaSources.put(idl, output);
274274
}
275-
return outputJavaSources.build();
275+
return outputJavaSources.buildOrThrow();
276276
}
277277

278278
/**

src/main/java/com/google/devtools/build/lib/rules/android/AndroidManifest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,11 +285,12 @@ private static Map<Artifact, Label> getMergeeManifests(
285285
}
286286
switch (manifestMergerOrder) {
287287
case ALPHABETICAL:
288-
return ImmutableSortedMap.copyOf(builder.build(), Artifact.EXEC_PATH_COMPARATOR);
288+
return ImmutableSortedMap.copyOf(builder.buildOrThrow(), Artifact.EXEC_PATH_COMPARATOR);
289289
case ALPHABETICAL_BY_CONFIGURATION:
290-
return ImmutableSortedMap.copyOf(builder.build(), Artifact.ROOT_RELATIVE_PATH_COMPARATOR);
290+
return ImmutableSortedMap.copyOf(
291+
builder.buildOrThrow(), Artifact.ROOT_RELATIVE_PATH_COMPARATOR);
291292
case DEPENDENCY:
292-
return builder.build();
293+
return builder.buildOrThrow();
293294
}
294295
throw new AssertionError(manifestMergerOrder);
295296
}

src/main/java/com/google/devtools/build/lib/rules/android/AndroidRuntimeJarProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ public Builder addDesugaredJar(Artifact jar, Artifact desugared) {
6464

6565
/** Returns the finished {@link AndroidRuntimeJarProvider}. */
6666
public AndroidRuntimeJarProvider build() {
67-
return new AndroidRuntimeJarProvider(transitiveMappings.add(newlyDesugared.build()).build());
67+
return new AndroidRuntimeJarProvider(
68+
transitiveMappings.add(newlyDesugared.buildOrThrow()).build());
6869
}
6970
}
7071

src/main/java/com/google/devtools/build/lib/rules/android/AndroidSplitTransition.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ private ImmutableMap<String, BuildOptions> handleAndroidPlatforms(
146146

147147
addNonCpuSplits(result, platform.getName(), splitOptions);
148148
}
149-
return result.build();
149+
return result.buildOrThrow();
150150
}
151151

152152
/** Returns a single-split transition that uses the "--cpu" and does not change any flags. */
@@ -156,7 +156,7 @@ private ImmutableMap<String, BuildOptions> handleDefaultSplit(
156156
ImmutableMap.Builder<String, BuildOptions> result = ImmutableMap.builder();
157157
result.put(cpu, buildOptions.underlying());
158158
addNonCpuSplits(result, cpu, buildOptions);
159-
return result.build();
159+
return result.buildOrThrow();
160160
}
161161

162162
/**
@@ -196,7 +196,7 @@ private ImmutableMap<String, BuildOptions> handleFatApkCpus(
196196
result.put(cpu, splitOptions.underlying());
197197
addNonCpuSplits(result, cpu, splitOptions);
198198
}
199-
return result.build();
199+
return result.buildOrThrow();
200200
}
201201

202202
private void setCcFlagsFromAndroid(

src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ public void buildAndRegister(String message, String mnemonic) {
352352
spawnActionBuilder.addCommandLine(commandLine.build(), FORCED_PARAM_FILE_INFO);
353353
}
354354

355-
spawnActionBuilder.setExecutionInfo(executionInfo.build());
355+
spawnActionBuilder.setExecutionInfo(executionInfo.buildOrThrow());
356356

357357
dataContext.registerAction(spawnActionBuilder);
358358
}

src/main/java/com/google/devtools/build/lib/runtime/BlazeServerStartupOptions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private String unescape(String input) {
5454
public Map<String, String> convert(String input) {
5555
ImmutableMap.Builder<String, String> builder = ImmutableMap.builder();
5656
if (input.isEmpty()) {
57-
return builder.build();
57+
return builder.buildOrThrow();
5858
}
5959

6060
String[] elements = input.split(":");
@@ -66,7 +66,7 @@ public Map<String, String> convert(String input) {
6666
}
6767
builder.put(unescape(name), unescape(value));
6868
}
69-
return builder.build();
69+
return builder.buildOrThrow();
7070
}
7171

7272
@Override

src/main/java/com/google/devtools/build/lib/runtime/BuildEventStreamer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,14 +370,14 @@ private synchronized void close(@Nullable AbortReason reason) {
370370
for (BuildEventTransport transport : transports) {
371371
closeFuturesMapBuilder.put(transport, transport.close());
372372
}
373-
closeFuturesMap = closeFuturesMapBuilder.build();
373+
closeFuturesMap = closeFuturesMapBuilder.buildOrThrow();
374374

375375
ImmutableMap.Builder<BuildEventTransport, ListenableFuture<Void>> halfCloseFuturesMapBuilder =
376376
ImmutableMap.builder();
377377
for (BuildEventTransport transport : transports) {
378378
halfCloseFuturesMapBuilder.put(transport, transport.getHalfCloseFuture());
379379
}
380-
halfCloseFuturesMap = halfCloseFuturesMapBuilder.build();
380+
halfCloseFuturesMap = halfCloseFuturesMapBuilder.buildOrThrow();
381381
}
382382

383383
private void maybeReportArtifactSet(CompletionContext ctx, NestedSet<?> set) {

src/main/java/com/google/devtools/build/lib/runtime/GCStatsRecorder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public GCStatsRecorder(Iterable<GarbageCollectorMXBean> mxBeans) {
3535
initialData.put(name, new GCStat(name, mxBean.getCollectionCount(),
3636
mxBean.getCollectionTime()));
3737
}
38-
this.initialData = initialData.build();
38+
this.initialData = initialData.buildOrThrow();
3939
}
4040

4141
public Iterable<GCStat> getCurrentGcStats() {

src/main/java/com/google/devtools/build/lib/runtime/ServerBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ InvocationPolicy getInvocationPolicy() {
6060
}
6161

6262
ImmutableMap<String, InfoItem> getInfoItems() {
63-
return infoItems.build();
63+
return infoItems.buildOrThrow();
6464
}
6565

6666
ImmutableList<QueryFunction> getQueryFunctions() {
@@ -196,6 +196,6 @@ public ServerBuilder addAuthHeadersProvider(
196196

197197
/** Returns a map of all registered {@link AuthHeadersProvider}s. */
198198
public ImmutableMap<String, AuthHeadersProvider> getAuthHeadersProvidersMap() {
199-
return authHeadersProvidersMap.build();
199+
return authHeadersProvidersMap.buildOrThrow();
200200
}
201201
}

0 commit comments

Comments
 (0)