DatePicker: improve form change validation (#12348)

wacky6 · jikkai · commit b70da53f157e · 2018-08-15T11:38:37.000+08:00
watch.value will keep firing during time picker selection
it now detects whether panel is closed before firing el.form.change
diff --git a/packages/date-picker/src/picker.vue b/packages/date-picker/src/picker.vue
@@ -429,7 +429,7 @@ export default {
       }
     },
     value(val, oldVal) {
-      if (!valueEquals(val, oldVal)) {
+      if (!valueEquals(val, oldVal) && !this.pickerVisible) {
         this.dispatch('ElFormItem', 'el.form.change', val);
       }
     }
@@ -893,6 +893,7 @@ export default {
       // determine user real change only
       if (!valueEquals(val, this.valueOnOpen)) {
         this.$emit('change', val);
+        this.dispatch('ElFormItem', 'el.form.change', val);
         this.valueOnOpen = val;
       }
     },

Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,7 @@ export default {`
`429`	`429`	`}`
`430`	`430`	`},`
`431`	`431`	`value(val, oldVal) {`
`432`		`- if (!valueEquals(val, oldVal)) {`
	`432`	`+ if (!valueEquals(val, oldVal) && !this.pickerVisible) {`
`433`	`433`	`this.dispatch('ElFormItem', 'el.form.change', val);`
`434`	`434`	`}`
`435`	`435`	`}`
`@@ -893,6 +893,7 @@ export default {`
`893`	`893`	`// determine user real change only`
`894`	`894`	`if (!valueEquals(val, this.valueOnOpen)) {`
`895`	`895`	`this.$emit('change', val);`
	`896`	`+ this.dispatch('ElFormItem', 'el.form.change', val);`
`896`	`897`	`this.valueOnOpen = val;`
`897`	`898`	`}`
`898`	`899`	`},`