Skip to content

Commit 899c990

Browse files
committed
[change] Changed to explicitly grant implicitly given key.
1 parent b799d2e commit 899c990

File tree

7 files changed

+40
-19
lines changed

7 files changed

+40
-19
lines changed

examples/components/side-nav.vue

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,10 @@
142142
</li>
143143
</ul>
144144
</li>
145-
<li class="nav-item" v-for="item in data">
145+
<li
146+
class="nav-item"
147+
v-for="(item, key) in data"
148+
:key="key">
146149
<a v-if="!item.path && !item.href" @click="expandMenu">{{item.name}}</a>
147150
<a v-if="item.href" :href="item.href" target="_blank">{{item.name}}</a>
148151
<router-link
@@ -153,7 +156,10 @@
153156
v-text="item.title || item.name">
154157
</router-link>
155158
<ul class="pure-menu-list sub-nav" v-if="item.children">
156-
<li class="nav-item" v-for="navItem in item.children">
159+
<li
160+
class="nav-item"
161+
v-for="(navItem, key) in item.children"
162+
:key="key">
157163
<router-link
158164
class=""
159165
active-class="active"
@@ -164,13 +170,18 @@
164170
</li>
165171
</ul>
166172
<template v-if="item.groups">
167-
<div class="nav-group" v-for="group in item.groups">
173+
<div
174+
class="nav-group"
175+
v-for="(group, key) in item.groups"
176+
:key="key"
177+
>
168178
<div class="nav-group__title" @click="expandMenu">{{group.groupName}}</div>
169179
<ul class="pure-menu-list">
170180
<li
171181
class="nav-item"
172-
v-for="navItem in group.list"
173-
v-if="!navItem.disabled">
182+
v-for="(navItem, key) in group.list"
183+
v-if="!navItem.disabled"
184+
:key="key">
174185
<router-link
175186
active-class="active"
176187
:to="base + navItem.path"

packages/date-picker/src/basic/date-table.vue

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,17 @@
99
<tbody>
1010
<tr>
1111
<th v-if="showWeekNumber">{{ t('el.datepicker.week') }}</th>
12-
<th v-for="week in WEEKS">{{ t('el.datepicker.weeks.' + week) }}</th>
12+
<th v-for="(week, key) in WEEKS" :key="key">{{ t('el.datepicker.weeks.' + week) }}</th>
1313
</tr>
1414
<tr
1515
class="el-date-table__row"
16-
v-for="row in rows"
17-
:class="{ current: isWeekActive(row[1]) }">
16+
v-for="(row, key) in rows"
17+
:class="{ current: isWeekActive(row[1]) }"
18+
:key="key">
1819
<td
19-
v-for="cell in row"
20-
:class="getCellClasses(cell)">
20+
v-for="(cell, key) in row"
21+
:class="getCellClasses(cell)"
22+
:key="key">
2123
<div>
2224
<span>
2325
{{ cell.text }}

packages/date-picker/src/basic/time-spinner.vue

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
@click="handleClick('seconds', { value: key, disabled: false })"
4646
v-for="(second, key) in 60"
4747
class="el-time-spinner__item"
48-
:class="{ 'active': key === seconds }">{{ ('0' + key).slice(-2) }}</li>
48+
:class="{ 'active': key === seconds }"
49+
:key="key">{{ ('0' + key).slice(-2) }}</li>
4950
</el-scrollbar>
5051
</template>
5152
<template v-if="arrowControl">
@@ -58,7 +59,8 @@
5859
<li
5960
class="el-time-spinner__item"
6061
:class="{ 'active': hour === hours, 'disabled': hoursList[hour] }"
61-
v-for="hour in arrowHourList">{{ hour === undefined ? '' : ('0' + (amPmMode ? (hour % 12 || 12) : hour )).slice(-2) + amPm(hour) }}</li>
62+
v-for="(hour, key) in arrowHourList"
63+
:key="key">{{ hour === undefined ? '' : ('0' + (amPmMode ? (hour % 12 || 12) : hour )).slice(-2) + amPm(hour) }}</li>
6264
</ul>
6365
</div>
6466
<div
@@ -70,7 +72,8 @@
7072
<li
7173
class="el-time-spinner__item"
7274
:class="{ 'active': minute === minutes }"
73-
v-for="minute in arrowMinuteList">
75+
v-for="(minute, key) in arrowMinuteList"
76+
:key="key">
7477
{{ minute === undefined ? '' : ('0' + minute).slice(-2) }}
7578
</li>
7679
</ul>
@@ -83,9 +86,10 @@
8386
<i v-repeat-click="increase" class="el-time-spinner__arrow el-icon-arrow-down"></i>
8487
<ul class="el-time-spinner__list" ref="seconds">
8588
<li
89+
v-for="(second, key) in arrowSecondList"
8690
class="el-time-spinner__item"
8791
:class="{ 'active': second === seconds }"
88-
v-for="second in arrowSecondList">
92+
:key="key">
8993
{{ second === undefined ? '' : ('0' + second).slice(-2) }}
9094
</li>
9195
</ul>

packages/date-picker/src/panel/date-range.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
<button
1414
type="button"
1515
class="el-picker-panel__shortcut"
16-
v-for="shortcut in shortcuts"
16+
v-for="(shortcut, key) in shortcuts"
17+
:key="key"
1718
@click="handleShortcutClick(shortcut)">{{shortcut.text}}</button>
1819
</div>
1920
<div class="el-picker-panel__body">

packages/date-picker/src/panel/date.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
<button
1414
type="button"
1515
class="el-picker-panel__shortcut"
16-
v-for="shortcut in shortcuts"
16+
v-for="(shortcut, key) in shortcuts"
17+
:key="key"
1718
@click="handleShortcutClick(shortcut)">{{ shortcut.text }}</button>
1819
</div>
1920
<div class="el-picker-panel__body">

packages/rate/src/main.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@
99
:aria-valuemax="max"
1010
tabindex="0">
1111
<span
12-
v-for="item in max"
12+
v-for="(item, key) in max"
1313
class="el-rate__item"
1414
@mousemove="setCurrentValue(item, $event)"
1515
@mouseleave="resetCurrentValue"
1616
@click="selectValue(item)"
17-
:style="{ cursor: rateDisabled ? 'auto' : 'pointer' }">
17+
:style="{ cursor: rateDisabled ? 'auto' : 'pointer' }"
18+
:key="key">
1819
<i
1920
:class="[classes[item - 1], { 'hover': hoverIndex === item }]"
2021
class="el-rate__icon"

packages/slider/src/main.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
</slider-button>
4646
<div
4747
class="el-slider__stop"
48-
v-for="item in stops"
48+
v-for="(item, key) in stops"
49+
:key="key"
4950
:style="vertical ? { 'bottom': item + '%' } : { 'left': item + '%' }"
5051
v-if="showStops">
5152
</div>

0 commit comments

Comments
 (0)