Fix Clazy warnings

Author: ElTh0r0

src/callmonitor.cpp

@@ -99,7 +99,7 @@ inline bool isRetryableError(QTcpSocket::SocketError socketError) {
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 
-void CallMonitor::onError(QTcpSocket::SocketError socketError) {
+void CallMonitor::onError(QAbstractSocket::SocketError socketError) {
   emit errorOccured(socketError,
                     m_pSocket->errorString() +
                         tr(" (Retry in %1 seconds ...)").arg(m_nRetryInterval));

src/callmonitor.h

@@ -48,15 +48,16 @@ class CallMonitor : public QObject {
   void parseAndSignal(const QString &sLine);
 
  signals:
-  void stateChanged(QTcpSocket::SocketState state);
-  void errorOccured(QTcpSocket::SocketError error, const QString &sMessage);
+  void stateChanged(QAbstractSocket::SocketState state);
+  void errorOccured(QAbstractSocket::SocketError error,
+                    const QString &sMessage);
 
   void incomingCall(unsigned connectionId, const QString &sCaller,
                     const QString &sCallee);
 
  private slots:
   void onConnected();
-  void onError(QTcpSocket::SocketError socketError);
+  void onError(QAbstractSocket::SocketError socketError);
   void onReadyRead();
 
  private:

src/fritzsoap.cpp

@@ -90,7 +90,7 @@ QString FritzSOAP::sendRequest(const QString &service, const QString &action,
   // greift)
   QObject::connect(
       &nam, &QNetworkAccessManager::authenticationRequired,
-      [this](QNetworkReply * /*reply*/, QAuthenticator *authenticator) {
+      [](QNetworkReply * /*reply*/, QAuthenticator *authenticator) {
         qDebug() << "authenticationRequired() triggered!";
         authenticator->setUser(Settings::instance()->getFritzUser());
         authenticator->setPassword(Settings::instance()->getFritzPassword());

src/onlineresolvers.cpp

@@ -66,7 +66,7 @@ OnlineResolvers::OnlineResolvers(QDir sharePath, QObject *pParent)
       QStringLiteral("URL"), QStringLiteral("NameRegExp"),
       QStringLiteral("CityRegExp")};
 
-  for (const auto &path : resolverPaths) {
+  for (const auto &path : std::as_const(resolverPaths)) {
     const QStringList resolverFiles =
         path.entryList(QStringList() << QStringLiteral("*.conf"),
                        QDir::Files | QDir::NoDotAndDotDot, QDir::Name);

src/phonebooks/carddav.cpp

@@ -146,7 +146,7 @@ void CardDAV::extractNumber(const QByteArray &xmlData,
       }
 
       QString sPhoneType;
-      for (const QString &lineRaw : telLines) {
+      for (const QString &lineRaw : std::as_const(telLines)) {
         // Example: TEL;TYPE=WORK,CELL:012345678
         QString line = lineRaw.trimmed();
 

src/phonebooks/fritzphonebook.cpp

@@ -119,7 +119,7 @@ QStringList FritzPhonebook::getPhonebookList() {
     qWarning() << "XML Parse Error:" << xml.errorString();
   }
 
-  for (const QString &idStr : phonebookIDs) {
+  for (const QString &idStr : std::as_const(phonebookIDs)) {
     bool ok = false;
     int id = idStr.toInt(&ok);
     if (!ok) {