Skip to content

Commit 7b0f583

Browse files
committed
add third parameter domainID/srcID to key in template cache for IPFix/v9
1 parent 093b7bf commit 7b0f583

File tree

2 files changed

+19
-20
lines changed

2 files changed

+19
-20
lines changed

ipfix/decoder.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,12 @@ func (d *Decoder) decodeSet(mem MemCache, msg *Message) error {
201201
mem.insert(tr.TemplateID, d.raddr, tr, msg.Header.DomainID)
202202
}
203203
} else if setID >= 4 && setID <= 255 {
204-
// Reserved set, do not read any records
205-
break
206-
} else if setID == 0 {
207-
// Invalid set
208-
return fmt.Errorf("failed to decodeSet / invalid setID")
209-
} else {
204+
// Reserved set, do not read any records
205+
break
206+
} else if setID == 0 {
207+
// Invalid set
208+
return fmt.Errorf("failed to decodeSet / invalid setID")
209+
} else {
210210
// Data set
211211
var data []DecodedField
212212
if data, err = d.decodeData(tr); err == nil {

ipfix/memcache_test.go

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -86,25 +86,24 @@ func TestMemCache_keyWithDifferentDomainIDs(t *testing.T) {
8686
tpl.TemplateID = 310
8787
tpl.FieldCount = 19
8888
mCache.insert(tpl.TemplateID, ip, tpl, 513)
89-
90-
tpl.FieldCount = 21
89+
tpl.FieldCount = 21
9190
mCache.insert(tpl.TemplateID, ip, tpl, 514)
9291

9392
v, ok := mCache.retrieve(tpl.TemplateID, ip, 513)
9493

95-
if !ok {
96-
t.Error("expected mCache retrieve status true, got", ok)
97-
}
98-
if v.FieldCount != 19 {
99-
t.Error("expected template id#:310 with Field count#:19, got", v.TemplateID, v.FieldCount)
100-
}
94+
if !ok {
95+
t.Error("expected mCache retrieve status true, got", ok)
96+
}
97+
if v.FieldCount != 19 {
98+
t.Error("expected template id#:310 with Field count#:19, got", v.TemplateID, v.FieldCount)
99+
}
101100

102101
v, ok = mCache.retrieve(tpl.TemplateID, ip, 514)
103102

104-
if !ok {
105-
t.Error("expected mCache retrieve status true, got", ok)
106-
}
107-
if v.FieldCount != 21 {
108-
t.Error("expected template id#:310 with Field count#:21, got", v.TemplateID, v.FieldCount)
109-
}
103+
if !ok {
104+
t.Error("expected mCache retrieve status true, got", ok)
105+
}
106+
if v.FieldCount != 21 {
107+
t.Error("expected template id#:310 with Field count#:21, got", v.TemplateID, v.FieldCount)
108+
}
110109
}

0 commit comments

Comments
 (0)