Skip to content

Commit 469045f

Browse files
committed
add group counts to output of summary functions
1 parent 913de58 commit 469045f

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

R/summarizeGroupComparisons.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ getGroupComparisonSummaryFunctionNames <- function() {
9494
})
9595

9696
new_fdata <- do.call(rbind, lapply(edata_cols, function(x) attr(x, "f_data")))
97-
new_edata <- data.frame(compData$e_data[, getEDataColName(compData)], do.call(cbind, edata_cols))
97+
new_fdata$Comparison_Summary_Column <- make.unique(new_fdata$Comparison_Summary_Column)
98+
new_edata <- data.frame(setNames(compData$e_data[, getEDataColName(compData)], getEDataColName(compData)), do.call(cbind, edata_cols))
9899
colnames(new_edata)[1] <- getEDataColName(compData)
99100

100101
if (inherits(compData, "peakData")) {

R/uniqueness_functions.R

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,13 @@ uniqueness_nsamps <- function(edata_df, group_df, data_scale, pres_thresh, absn_
8181
res_vec[which(numpres$N_grp1 <= absn_thresh & numpres$N_grp2 >= pres_thresh)] = paste("Unique to", grps[2], sep = " ")
8282

8383
lvls <- c(paste("Unique to", grps), "Observed in Both")
84-
data.frame(uniqueness_nsamps = factor(res_vec, levels = lvls))
84+
out_df = data.frame(uniqueness_nsamps = factor(res_vec, levels = lvls))
85+
out_df = dplyr::bind_cols(
86+
out_df,
87+
numpres
88+
)
89+
90+
return(out_df)
8591
}
8692

8793

@@ -161,7 +167,16 @@ uniqueness_prop <- function(edata_df, group_df, data_scale, pres_thresh, absn_th
161167
res_vec[which(prop_pres$prop_grp1 <= absn_thresh & prop_pres$prop_grp2 >= pres_thresh)] = paste("Unique to", grps[2], sep = " ")
162168

163169
lvls <- c(paste("Unique to", grps), "Observed in Both")
164-
data.frame(uniqueness_prop = factor(res_vec, levels=lvls))
170+
out_df = data.frame(
171+
uniqueness_prop = factor(res_vec, levels=lvls)
172+
)
173+
174+
out_df = dplyr::bind_cols(
175+
out_df,
176+
prop_pres
177+
)
178+
179+
return(out_df)
165180
}
166181

167182

tests/testthat/test_summarizeComparisons.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,13 @@ test_that("test of summarizeGroupComparisons with multiple summary functions on
7070

7171
expect_true(inherits(grpCompSummary, "comparisonSummary"))
7272
expect_false(inherits(grpCompSummary, "groupComparison"))
73-
expect_equal(ncol(grpCompSummary$e_data), 7)
73+
expect_equal(ncol(grpCompSummary$e_data), 11)
7474
expect_true(getEDataColName(grpComp) %in% colnames(grpCompSummary$e_data))
7575
expect_true(all(dim(grpComp$e_meta) == dim(grpCompSummary$e_meta)))
7676
expect_true(all(colnames(grpComp$e_meta) %in% colnames(grpCompSummary$e_meta)))
7777
expect_true(all(c("uniqueness_gtest", "uniqueness_nsamps", "uniqueness_prop") %in%
7878
grpCompSummary$f_data$Summary_Function_Name))
79-
expect_equal(nrow(grpCompSummary$f_data), 6)
79+
expect_equal(nrow(grpCompSummary$f_data), 10)
8080
expect_true(all(unlist(lapply(grpCompSummary$e_data[, 2], function(x) is.factor(x)))))
8181

8282
})

0 commit comments

Comments
 (0)