Skip to content

Commit 43b7002

Browse files
committed
fix(properties): use setter for columns property
1 parent 6ae681b commit 43b7002

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

anonip.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,7 @@ def __init__(
8989
:param replace: str
9090
:param skip_private: bool
9191
"""
92-
columns = columns if columns else [1]
93-
# change columns to be 0-based
94-
self.columns = [c - 1 for c in columns]
92+
self.columns = columns
9593
self._prefixes = {} # next two lines will fill the values
9694
self.ipv4mask = ipv4mask
9795
self.ipv6mask = ipv6mask
@@ -100,6 +98,15 @@ def __init__(
10098
self.replace = replace
10199
self.skip_private = skip_private
102100

101+
@property
102+
def columns(self):
103+
return self._columns
104+
105+
@columns.setter
106+
def columns(self, columns):
107+
# change columns to be 0-based
108+
self._columns = [c - 1 for c in columns] if columns else [0]
109+
103110
@property
104111
def ipv4mask(self):
105112
return self._ipv4mask

tests.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,3 +310,10 @@ def test_properties_v6():
310310
a = anonip.Anonip(ipv4mask=11, ipv6mask=83)
311311
assert a.ipv6mask == 83
312312
assert a._prefixes[6] == 45
313+
314+
315+
def test_properties_columns():
316+
a = anonip.Anonip()
317+
assert a.columns == [0]
318+
a.columns = [5, 6]
319+
assert a.columns == [4, 5]

0 commit comments

Comments
 (0)