Remove duplicate semantic tokens for readonly properties

Author: ValdezFOmar

packages/pyright-internal/src/analyzer/semanticTokensWalker.ts

@@ -1,23 +1,13 @@
 import { ParseTreeWalker } from './parseTreeWalker';
 import { TypeEvaluator } from './typeEvaluatorTypes';
-import {
-    ClassType,
-    FunctionType,
-    getTypeAliasInfo,
-    isClass,
-    OverloadedType,
-    Type,
-    TypeBase,
-    TypeCategory,
-} from './types';
+import { ClassType, FunctionType, getTypeAliasInfo, OverloadedType, Type, TypeBase, TypeCategory } from './types';
 import {
     ClassNode,
     DecoratorNode,
     FunctionNode,
     ImportAsNode,
     ImportFromAsNode,
     ImportFromNode,
-    MemberAccessNode,
     NameNode,
     ParameterNode,
     ParseNodeType,
@@ -144,19 +134,6 @@ export class SemanticTokensWalker extends ParseTreeWalker {
         return super.visitTypeAlias(node);
     }
 
-    override visitMemberAccess(node: MemberAccessNode): boolean {
-        // check for properties without a setter
-        if (node.parent && this._evaluator) {
-            const declaredType = this._evaluator.getDeclaredTypeForExpression(node, {
-                method: 'set',
-            });
-            if (declaredType && isClass(declaredType) && ClassType.isPropertyClass(declaredType)) {
-                this._addItemForNameNode(node.d.member, SemanticTokenTypes.variable, [SemanticTokenModifiers.readonly]);
-            }
-        }
-        return super.visitMemberAccess(node);
-    }
-
     private _visitNameWithType(node: NameNode, type: Type) {
         switch (type.category) {
             case TypeCategory.Any:

packages/pyright-internal/src/tests/semanticTokensProvider.test.ts

@@ -77,15 +77,13 @@ if (process.platform !== 'win32' || !process.env['CI']) {
             { type: 'selfParameter', modifiers: ['definition'], start: 198, length: 4 },
             { type: 'parameter', modifiers: ['definition'], start: 204, length: 5 },
             { type: 'class', modifiers: ['defaultLibrary', 'builtin'], start: 211, length: 3 },
-            { type: 'variable', modifiers: ['readonly'], start: 229, length: 3 },
             { type: 'class', modifiers: [], start: 223, length: 3 },
             { type: 'variable', modifiers: ['readonly'], start: 229, length: 3 },
             { type: 'class', modifiers: [], start: 233, length: 3 },
             { type: 'variable', modifiers: [], start: 239, length: 3 },
             { type: 'variable', modifiers: [], start: 244, length: 3 },
             { type: 'class', modifiers: [], start: 250, length: 3 },
             { type: 'variable', modifiers: [], start: 256, length: 1 },
-            { type: 'variable', modifiers: ['readonly'], start: 264, length: 3 },
             { type: 'variable', modifiers: [], start: 260, length: 3 },
             { type: 'variable', modifiers: ['readonly'], start: 264, length: 3 },
         ]);