Increase IAST propagation to StringBuffer subSequence (#8038)

Mariovido · web-flow · commit 9918d219cfe0 · 2024-12-12T13:09:46.000+01:00
diff --git a/dd-java-agent/instrumentation/java-lang/src/main/java/datadog/trace/instrumentation/java/lang/StringBuilderCallSite.java b/dd-java-agent/instrumentation/java-lang/src/main/java/datadog/trace/instrumentation/java/lang/StringBuilderCallSite.java
@@ -162,6 +162,7 @@ public static String afterSubstring(
   }
 
   @CallSite.After("java.lang.CharSequence java.lang.StringBuilder.subSequence(int, int)")
+  @CallSite.After("java.lang.CharSequence java.lang.StringBuffer.subSequence(int, int)")
   public static CharSequence afterSubSequence(
       @CallSite.This final CharSequence self,
       @CallSite.Argument final int beginIndex,
diff --git a/dd-java-agent/instrumentation/java-lang/src/test/groovy/datadog/trace/instrumentation/java/lang/StringBuilderCallSiteTest.groovy b/dd-java-agent/instrumentation/java-lang/src/test/groovy/datadog/trace/instrumentation/java/lang/StringBuilderCallSiteTest.groovy
@@ -246,6 +246,7 @@ class StringBuilderCallSiteTest extends AgentTestRunner {
     where:
     type      | suite                        | param         | beginIndex | endIndex | expected
     "builder" | new TestStringBuilderSuite() | sb('012345')  | 1          | 5        | '1234'
+    "buffer"  | new TestStringBufferSuite()  | sbf('012345') | 1          | 5        | '1234'
   }
 
   private static class BrokenToString {

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ public static String afterSubstring(`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`@CallSite.After("java.lang.CharSequence java.lang.StringBuilder.subSequence(int, int)")`
	`165`	`+ @CallSite.After("java.lang.CharSequence java.lang.StringBuffer.subSequence(int, int)")`
`165`	`166`	`public static CharSequence afterSubSequence(`
`166`	`167`	`@CallSite.This final CharSequence self,`
`167`	`168`	`@CallSite.Argument final int beginIndex,`
Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,7 @@ class StringBuilderCallSiteTest extends AgentTestRunner {`
`246`	`246`	`where:`
`247`	`247`	`type \| suite \| param \| beginIndex \| endIndex \| expected`
`248`	`248`	`"builder" \| new TestStringBuilderSuite() \| sb('012345') \| 1 \| 5 \| '1234'`
	`249`	`+ "buffer" \| new TestStringBufferSuite() \| sbf('012345') \| 1 \| 5 \| '1234'`
`249`	`250`	`}`
`250`	`251`
`251`	`252`	`private static class BrokenToString {`