Skip to content

Commit c7d03b1

Browse files
authored
[CI] Stop running windows throughput tests (#6752)
## Summary of changes Removes the Windows throughput tests ## Reason for change They've been broken for ~3 weeks, nobody's looking at them, they slow down the pipelines, and we're migrating to the benchmarking platform anyway ## Implementation details Delete the Windows job from the throughput stage - I've left all the other infra for it, as we will likely remove _all_ of the crank stuff post- benchmarking platform transition ## Test coverage This is the test ## Other details Hopefully the compare stage works, this PR will show if it doesn't though
1 parent 7086540 commit c7d03b1

File tree

1 file changed

+1
-61
lines changed

1 file changed

+1
-61
lines changed

.azure-pipelines/ultimate-pipeline.yml

Lines changed: 1 addition & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -4641,7 +4641,7 @@ stages:
46414641
jobs:
46424642
- template: steps/update-github-status-jobs.yml
46434643
parameters:
4644-
jobs: [Linux64, Windows64, LinuxArm64]
4644+
jobs: [Linux64, LinuxArm64]
46454645
allowSkipped: true
46464646
#### Throughput Linux 64, Windows 64, Linux arm 64
46474647

@@ -4698,59 +4698,6 @@ stages:
46984698
# stages without issue
46994699
artifact: crank_linux_x64_1
47004700

4701-
- job: Windows64
4702-
timeoutInMinutes: 60
4703-
pool: Throughput
4704-
4705-
steps:
4706-
- template: steps/clone-repo.yml
4707-
parameters:
4708-
targetShaId: $(targetShaId)
4709-
targetBranch: $(targetBranch)
4710-
4711-
- task: DownloadPipelineArtifact@2
4712-
displayName: Download windows native binary
4713-
inputs:
4714-
artifact: windows-tracer-home
4715-
path: $(System.DefaultWorkingDirectory)/tracer/tracer-home-win
4716-
4717-
- task: DownloadPipelineArtifact@2
4718-
displayName: Download Datadog.Trace.Manual
4719-
inputs:
4720-
artifact: build-windows-working-directory
4721-
itemPattern: tracer/src/Datadog.Trace.Manual/bin/Release/netcoreapp3.1/Datadog.Trace.Manual.dll
4722-
path: $(Agent.TempDirectory)
4723-
4724-
- script: |
4725-
mkdir -p tracer/bin/netcoreapp3.1
4726-
cp $(Agent.TempDirectory)/tracer/src/Datadog.Trace.Manual/bin/Release/netcoreapp3.1/Datadog.Trace.Manual.dll tracer/bin/netcoreapp3.1/
4727-
test ! -s "tracer/tracer-home-win/win-x64/Datadog.Trace.ClrProfiler.Native.dll" && echo "tracer/tracer-home-win/win-x64/Datadog.Trace.ClrProfiler.Native.dll (native loader) does not exist" && exit 1
4728-
test ! -s "tracer/tracer-home-win/win-x64/Datadog.Tracer.Native.dll" && echo "tracer/tracer-home-win/win-x64/Datadog.Tracer.Native.dll does not exist" && exit 1
4729-
test ! -s "tracer/tracer-home-win/win-x64/ddwaf.dll" && echo "tracer/tracer-home-win/win-x64/ddwaf.dll does not exist" && exit 1
4730-
test ! -s "tracer/bin/netcoreapp3.1/Datadog.Trace.Manual.dll" && echo "tracer/bin/netcoreapp3.1/Datadog.Trace.Manual.dll does not exist" && exit 1
4731-
mkdir -p $(CrankDir)/results/logs
4732-
cd $(CrankDir)
4733-
chmod +x ./run.sh
4734-
./run.sh "windows" "$(runExtendedThroughputTests)"
4735-
displayName: Crank tracer
4736-
env:
4737-
DD_SERVICE: dd-trace-dotnet
4738-
DD_ENV: CI
4739-
DD_CIVISIBILITY_AGENTLESS_ENABLED: true
4740-
DD_API_KEY: $(ddApiKey)
4741-
4742-
- script: |
4743-
cp $(CrankDir)/*.json $(CrankDir)/results
4744-
displayName: Copy the results to results dir
4745-
4746-
- publish: "$(CrankDir)/results"
4747-
displayName: Publish results
4748-
# We don't include the JobAttempt in this case, because we rely on a specific name
4749-
# and an error in the throughput tests probably means no usable data, so dont
4750-
# bother trying to upload these in case of failure, which means we can retry the
4751-
# stages without issue
4752-
artifact: crank_windows_x64_1
4753-
47544701
- job: LinuxArm64
47554702
timeoutInMinutes: 60
47564703
pool: Throughput
@@ -7083,13 +7030,6 @@ stages:
70837030
artifact: crank_linux_x64_1
70847031
path: $(System.DefaultWorkingDirectory)/artifacts/build_data/throughput/current/crank_linux_x64_1
70857032

7086-
- task: DownloadPipelineArtifact@2
7087-
displayName: Download crank_windows_x64_1
7088-
continueOnError: true
7089-
inputs:
7090-
artifact: crank_windows_x64_1
7091-
path: $(System.DefaultWorkingDirectory)/artifacts/build_data/throughput/current/crank_windows_x64_1
7092-
70937033
- script: tracer\build.cmd CompareThroughputResults
70947034
displayName: Compare Crank results
70957035
env:

0 commit comments

Comments
 (0)