Skip to content

Commit b7586c6

Browse files
committed
Do not skip on .net8 x86
1 parent 57d5335 commit b7586c6

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

tracer/test/Datadog.Trace.Debugger.IntegrationTests/DebuggerManagerDynamicTests.cs

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ public DebuggerManagerDynamicTests(ITestOutputHelper output)
5050
[Trait("Category", "LinuxUnsupported")]
5151
public async Task DebuggerManager_DynamicInstrumentation_StartDisabled_EnabledViaRemoteConfig()
5252
{
53-
#if NET8_0_OR_GREATER
54-
// These tests often hang on x86 on .NET 8+. Needs investigation
55-
Skip.If(!EnvironmentTools.IsTestTarget64BitProcess());
56-
#endif
57-
5853
// Set it true so we won't go through path of no debugger products at all
5954
SetEnvironmentVariable(ConfigurationKeys.Debugger.CodeOriginForSpansEnabled, "true");
6055
SetEnvironmentVariable(ConfigurationKeys.Rcm.RemoteConfigurationEnabled, "true");
@@ -84,9 +79,6 @@ await RunDynamicConfigurationTest(
8479
[Trait("Category", "LinuxUnsupported")]
8580
public async Task DebuggerManager_ExceptionReplay_StartDisabled_EnabledViaRemoteConfig()
8681
{
87-
#if NET8_0_OR_GREATER
88-
Skip.If(!EnvironmentTools.IsTestTarget64BitProcess());
89-
#endif
9082
SetEnvironmentVariable(ConfigurationKeys.Rcm.RemoteConfigurationEnabled, "true");
9183

9284
await RunDynamicConfigurationTest(
@@ -107,10 +99,6 @@ await RunDynamicConfigurationTest(
10799
[Trait("Category", "LinuxUnsupported")]
108100
public async Task DebuggerManager_CodeOrigin_StartDisabled_EnabledViaRemoteConfig()
109101
{
110-
#if NET8_0_OR_GREATER
111-
Skip.If(!EnvironmentTools.IsTestTarget64BitProcess());
112-
#endif
113-
114102
SetEnvironmentVariable(ConfigurationKeys.Rcm.RemoteConfigurationEnabled, "true");
115103

116104
await RunDynamicConfigurationTest(
@@ -131,9 +119,6 @@ await RunDynamicConfigurationTest(
131119
[Trait("Category", "LinuxUnsupported")]
132120
public async Task DebuggerManager_MultipleProducts_StartDisabled_EnabledViaRemoteConfig()
133121
{
134-
#if NET8_0_OR_GREATER
135-
Skip.If(!EnvironmentTools.IsTestTarget64BitProcess());
136-
#endif
137122
SetEnvironmentVariable(ConfigurationKeys.Rcm.RemoteConfigurationEnabled, "true");
138123

139124
await RunDynamicConfigurationTest(
@@ -174,10 +159,6 @@ await RunDynamicConfigurationTest(
174159
[Trait("Category", "LinuxUnsupported")]
175160
public async Task DebuggerManager_DynamicInstrumentation_StartEnabled_DisabledViaRemoteConfig()
176161
{
177-
#if NET8_0_OR_GREATER
178-
Skip.If(!EnvironmentTools.IsTestTarget64BitProcess());
179-
#endif
180-
181162
// Start with DI enabled via environment variable
182163
SetEnvironmentVariable(ConfigurationKeys.Debugger.DynamicInstrumentationEnabled, "true");
183164
SetEnvironmentVariable(ConfigurationKeys.Rcm.RemoteConfigurationEnabled, "true");
@@ -209,9 +190,6 @@ await RunDynamicConfigurationTest(
209190
[Trait("Category", "LinuxUnsupported")]
210191
public async Task DebuggerManager_ExceptionReplay_StartEnabled_DisabledViaRemoteConfig()
211192
{
212-
#if NET8_0_OR_GREATER
213-
Skip.If(!EnvironmentTools.IsTestTarget64BitProcess());
214-
#endif
215193
// Start with Exception Replay enabled via environment variable
216194
SetEnvironmentVariable(ConfigurationKeys.Debugger.ExceptionReplayEnabled, "true");
217195
SetEnvironmentVariable(ConfigurationKeys.Rcm.RemoteConfigurationEnabled, "true");
@@ -234,10 +212,6 @@ await RunDynamicConfigurationTest(
234212
[Trait("Category", "LinuxUnsupported")]
235213
public async Task DebuggerManager_CodeOrigin_StartEnabled_DisabledViaRemoteConfig()
236214
{
237-
#if NET8_0_OR_GREATER
238-
Skip.If(!EnvironmentTools.IsTestTarget64BitProcess());
239-
#endif
240-
241215
SetEnvironmentVariable(ConfigurationKeys.Rcm.RemoteConfigurationEnabled, "true");
242216
SetEnvironmentVariable(ConfigurationKeys.Debugger.CodeOriginForSpansEnabled, "true");
243217

0 commit comments

Comments
 (0)