Remove more [PublicApi] usages and unused code (#7786)

## Summary of changes

- Remove `[PublicApi]` usages that aren't necessary any more
- Rename `DebugEnabledInternal` => `DebugEnabled`
- Delete some "public" methods that aren't, and are no longer necessary
(as they're unused)

## Reason for change

Cleaning up

## Implementation details

Mostly <kbd>del</kbd>

## Test coverage

Covered by existing

## Other details


Part of a stack

- #7786 👈
- #7787
- #7788

Author: andrewlock

tracer/src/Datadog.Trace.Coverage.collector/DataCollectorLogger.cs

@@ -26,7 +26,7 @@ public DataCollectorLogger(DataCollectionLogger logger, DataCollectionContext co
         {
             _logger = logger;
             _collectionContext = collectionContext;
-            _isDebugEnabled = GlobalSettings.Instance.DebugEnabledInternal;
+            _isDebugEnabled = GlobalSettings.Instance.DebugEnabled;
 
             if (DatadogLoggingFactory.GetConfiguration(GlobalConfigurationSource.Instance, TelemetryFactory.Config).File is { } fileConfig)
             {

tracer/src/Datadog.Trace.Manual/ITracer.cs

@@ -30,7 +30,6 @@ public interface ITracer
         /// </summary>
         /// <param name="operationName">The span's operation name</param>
         /// <returns>A scope wrapping the newly created span</returns>
-        [PublicApi]
         IScope StartActive(string operationName);
 
         /// <summary>

tracer/src/Datadog.Trace.Manual/SourceGenerators/PublicApiAttribute.cs

@@ -23,7 +23,6 @@ public static class OpenTracingTracerFactory
         /// <param name="defaultServiceName">Default name of the service (default is the name of the executing assembly).</param>
         /// <param name="isDebugEnabled">Turns on all debug logging (this may have an impact on application performance).</param>
         /// <returns>A Datadog compatible ITracer implementation</returns>
-        [PublicApi]
         [Obsolete(DeprecationMessage)]
         [Instrumented]
         [MethodImpl(MethodImplOptions.NoInlining)]
@@ -54,7 +53,6 @@ public static class OpenTracingTracerFactory
         /// </summary>
         /// <param name="tracer">Existing Datadog Tracer instance</param>
         /// <returns>A Datadog compatible ITracer implementation</returns>
-        [PublicApi]
         [Obsolete(DeprecationMessage)]
         [Instrumented]
         [MethodImpl(MethodImplOptions.NoInlining)]

tracer/src/Datadog.Trace.OpenTracing/OpenTracingTracerFactory.cs

@@ -121,7 +121,7 @@ private void Execute(InvocationContext context)
                         }
                     }
 
-                    if (GlobalSettings.Instance.DebugEnabledInternal)
+                    if (GlobalSettings.Instance.DebugEnabled)
                     {
                         Console.WriteLine("Running: {0}", cmdLine);
                     }

tracer/src/Datadog.Trace.Tools.Runner/LegacyCommand.cs

@@ -59,7 +59,7 @@ private async Task ExecuteAsync(InvocationContext context)
             }
 
             // Run child process
-            if (GlobalSettings.Instance.DebugEnabledInternal)
+            if (GlobalSettings.Instance.DebugEnabled)
             {
                 Console.WriteLine("Running: {0}", command);
             }

tracer/src/Datadog.Trace.Tools.Runner/RunCiCommand.cs

@@ -42,7 +42,7 @@ private void Execute(InvocationContext context)
                 return;
             }
 
-            if (GlobalSettings.Instance.DebugEnabledInternal)
+            if (GlobalSettings.Instance.DebugEnabled)
             {
                 Console.WriteLine("Running: {0} {1}", program, arguments);
             }

tracer/src/Datadog.Trace.Tools.Runner/RunCommand.cs

@@ -548,7 +548,7 @@ private void InitWafAndInstrumentations()
                 _settings.ObfuscationParameterValueRegex,
                 _configurationState,
                 _settings.UseUnsafeEncoder,
-                GlobalSettings.Instance.DebugEnabledInternal && _settings.WafDebugEnabled);
+                GlobalSettings.Instance.DebugEnabled && _settings.WafDebugEnabled);
             if (_wafInitResult.Success)
             {
                 // we don't reapply configurations to the waf here because it's all done in the subscription function, as new data might have been received at the same time as the enable command, we don't want to update twice (here and in the subscription)

tracer/src/Datadog.Trace/AppSec/Security.cs

@@ -33,7 +33,7 @@ internal sealed class CIWriterHttpSender : ICIVisibilityProtocolWriterSender
     public CIWriterHttpSender(IApiRequestFactory apiRequestFactory)
     {
         _apiRequestFactory = apiRequestFactory;
-        _isDebugEnabled = GlobalSettings.Instance.DebugEnabledInternal;
+        _isDebugEnabled = GlobalSettings.Instance.DebugEnabled;
         Log.Information("CIWriterHttpSender Initialized.");
     }
 

tracer/src/Datadog.Trace/Ci/Agent/CIWriterHttpSender.cs

@@ -55,7 +55,6 @@ public void Add(IConfigurationSource source)
         IEnumerator<IConfigurationSource> IEnumerable<IConfigurationSource>.GetEnumerator() => _sources.GetEnumerator();
 
         /// <inheritdoc />
-        [PublicApi]
         IEnumerator IEnumerable.GetEnumerator() => _sources.GetEnumerator();
 
         /// <inheritdoc />