tests: match request body #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
|
jirikuncar
added
changelog/no-changelog
zippolyte
reviewed
Jul 27, 2020
tests/test_utils.go
Outdated
Comment on lines
355
to
358
| if strings.HasPrefix(r.Header["Content-Type"][0], "multipart/form-data") { | ||
| fmt.Printf("skip %s ??? %s", b.String(), i.Body) | ||
| return true | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This was a hot fix for multipart/form-data that are not exactly the same for some reason even when the content is the same.
zippolyte
reviewed
Jul 27, 2020
tests/test_utils.go
Outdated
| fmt.Printf("skip %s ??? %s", b.String(), i.Body) | ||
| return true | ||
| } | ||
| matched := (b.String() == "" || b.String() == i.Body) |
Contributor
There was a problem hiding this comment.
why is it a match if the body is empty and different than the recorded body ?
Contributor
Author
There was a problem hiding this comment.
It's related to GET requests that do not contain body.
Contributor
There was a problem hiding this comment.
But shouldn't it be equal to the recorded body i.Body anyway ?
bkabrda
reviewed
Jul 27, 2020
jirikuncar
commented
Jul 27, 2020
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request body must match recorded one in cassettes.