Skip to content

Normalize phrasing across rate/trace_rate in APM Retention Filters #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Normalize phrasing across rate/trace_rate in APM Retention Filters #3025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-11 15:05:34.141217",
"spec_repo_commit": "d209cd40"
"regenerated": "2025-04-14 08:41:58.923641",
"spec_repo_commit": "e73254d7"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-11 15:05:34.166826",
"spec_repo_commit": "d209cd40"
"regenerated": "2025-04-14 08:41:58.939474",
"spec_repo_commit": "e73254d7"
}
}
}
16 changes: 8 additions & 8 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25398,9 +25398,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down Expand Up @@ -25465,9 +25465,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down Expand Up @@ -25498,9 +25498,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down Expand Up @@ -25577,9 +25577,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down
4 changes: 2 additions & 2 deletions api/datadogV2/model_retention_filter_all_attributes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ type RetentionFilterAllAttributes struct {
ModifiedBy *string `json:"modified_by,omitempty"`
// The name of the retention filter.
Name *string `json:"name,omitempty"`
// Sample rate to apply to spans going through this retention filter,
// a value of 1.0 keeps all spans matching the query.
// Sample rate to apply to spans going through this retention filter.
// A value of 1.0 keeps all spans matching the query.
Rate *float64 `json:"rate,omitempty"`
// Sample rate to apply to traces containing spans going through this retention filter.
// A value of 1.0 keeps all traces with spans matching the query.
Expand Down
4 changes: 2 additions & 2 deletions api/datadogV2/model_retention_filter_attributes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ type RetentionFilterAttributes struct {
ModifiedBy *string `json:"modified_by,omitempty"`
// The name of the retention filter.
Name *string `json:"name,omitempty"`
// Sample rate to apply to spans going through this retention filter,
// a value of 1.0 keeps all spans matching the query.
// Sample rate to apply to spans going through this retention filter.
// A value of 1.0 keeps all spans matching the query.
Rate *float64 `json:"rate,omitempty"`
// Sample rate to apply to traces containing spans going through this retention filter.
// A value of 1.0 keeps all traces with spans matching the query.
Expand Down
4 changes: 2 additions & 2 deletions api/datadogV2/model_retention_filter_create_attributes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ type RetentionFilterCreateAttributes struct {
FilterType RetentionFilterType `json:"filter_type"`
// The name of the retention filter.
Name string `json:"name"`
// Sample rate to apply to spans going through this retention filter,
// a value of 1.0 keeps all spans matching the query.
// Sample rate to apply to spans going through this retention filter.
// A value of 1.0 keeps all spans matching the query.
Rate float64 `json:"rate"`
// Sample rate to apply to traces containing spans going through this retention filter.
// A value of 1.0 keeps all traces with spans matching the query.
Expand Down
4 changes: 2 additions & 2 deletions api/datadogV2/model_retention_filter_update_attributes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ type RetentionFilterUpdateAttributes struct {
FilterType RetentionFilterAllType `json:"filter_type"`
// The name of the retention filter.
Name string `json:"name"`
// Sample rate to apply to spans going through this retention filter,
// a value of 1.0 keeps all spans matching the query.
// Sample rate to apply to spans going through this retention filter.
// A value of 1.0 keeps all spans matching the query.
Rate float64 `json:"rate"`
// Sample rate to apply to traces containing spans going through this retention filter.
// A value of 1.0 keeps all traces with spans matching the query.
Expand Down