[Synthetics] Fix required target in assertions and type in step results (#1201)

* [Synthetics] Update tests for assertions

* Regenerate client from commit 6ddcc8e of spec repo

Co-authored-by: Romain Berger <[email protected]>
Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>
Co-authored-by: ci.datadog-api-spec <[email protected]>

Author: 3 people

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.5.1.dev2",
-            "regenerated": "2021-11-11 09:29:58.022073",
-            "spec_repo_commit": "904c411"
+            "regenerated": "2021-11-11 11:44:21.239708",
+            "spec_repo_commit": "6ddcc8e"
         },
         "v2": {
             "apigentools_version": "1.5.1.dev2",
-            "regenerated": "2021-11-11 09:29:58.043886",
-            "spec_repo_commit": "904c411"
+            "regenerated": "2021-11-11 11:44:21.260549",
+            "spec_repo_commit": "6ddcc8e"
         }
     }
 }

.generator/schemas/v1/openapi.yaml

@@ -9251,7 +9251,8 @@ components:
       properties:
         assertions:
           default: []
-          description: Array of assertions used for the test.
+          description: Array of assertions used for the test. Required for single
+            API tests.
           example:
           - operator: lessThan
             target: 1000
@@ -9458,12 +9459,14 @@ components:
           type: string
         target:
           description: Value used by the operator.
+          example: 123456
           nullable: false
         type:
           $ref: '#/components/schemas/SyntheticsAssertionType'
       required:
       - type
       - operator
+      - target
       type: object
     SyntheticsAssertionType:
       description: Type of the assertion.
@@ -9859,7 +9862,7 @@ components:
       description: Git information.
       properties:
         branch:
-          description: The branch name.
+          description: Branch name.
           type: string
         commitSha:
           description: The commit SHA.
@@ -10590,7 +10593,6 @@ components:
           type: string
         value:
           description: Value for the step.
-          type: object
         vitalsMetrics:
           description: Array of Core Web Vitals metrics for the step.
           items:

api/v1/datadog/api/openapi.yaml

@@ -21944,7 +21944,8 @@ components:
       properties:
         assertions:
           default: []
-          description: Array of assertions used for the test.
+          description: Array of assertions used for the test. Required for single
+            API tests.
           example:
           - operator: lessThan
             target: 1000
@@ -22298,11 +22299,13 @@ components:
           type: string
         target:
           description: Value used by the operator.
+          example: 123456
           nullable: false
         type:
           $ref: '#/components/schemas/SyntheticsAssertionType'
       required:
       - operator
+      - target
       - type
       type: object
     SyntheticsAssertionType:
@@ -22788,7 +22791,7 @@ components:
           subTestStepDetails:
           - null
           - null
-          value: '{}'
+          value: ""
         - screenshotBucketKey: true
           snapshotBucketKey: true
           warnings:
@@ -22823,7 +22826,7 @@ components:
           subTestStepDetails:
           - null
           - null
-          value: '{}'
+          value: ""
         browserType: browserType
       properties:
         browserType:
@@ -22919,7 +22922,7 @@ components:
             subTestStepDetails:
             - null
             - null
-            value: '{}'
+            value: ""
           - screenshotBucketKey: true
             snapshotBucketKey: true
             warnings:
@@ -22954,7 +22957,7 @@ components:
             subTestStepDetails:
             - null
             - null
-            value: '{}'
+            value: ""
           browserType: browserType
         check_version: 6
         probe_dc: probe_dc
@@ -23165,7 +23168,7 @@ components:
         branch: branch
       properties:
         branch:
-          description: The branch name.
+          description: Branch name.
           type: string
         commitSha:
           description: The commit SHA.
@@ -24315,7 +24318,7 @@ components:
         subTestStepDetails:
         - null
         - null
-        value: '{}'
+        value: ""
       properties:
         browserErrors:
           description: Array of errors collected for a browser test.
@@ -24367,7 +24370,6 @@ components:
           type: string
         value:
           description: Value for the step.
-          type: object
         vitalsMetrics:
           description: Array of Core Web Vitals metrics for the step.
           items:

api/v1/datadog/docs/SyntheticsAPITestConfig.md

@@ -4,7 +4,7 @@
 
 Name | Type | Description | Notes
 ---- | ---- | ----------- | ------
-**Assertions** | Pointer to [**[]SyntheticsAssertion**](SyntheticsAssertion.md) | Array of assertions used for the test. | [optional] [default to []]
+**Assertions** | Pointer to [**[]SyntheticsAssertion**](SyntheticsAssertion.md) | Array of assertions used for the test. Required for single API tests. | [optional] [default to []]
 **ConfigVariables** | Pointer to [**[]SyntheticsConfigVariable**](SyntheticsConfigVariable.md) | Array of variables used for the test. | [optional] 
 **Request** | Pointer to [**SyntheticsTestRequest**](SyntheticsTestRequest.md) |  | [optional] 
 **Steps** | Pointer to [**[]SyntheticsAPIStep**](SyntheticsAPIStep.md) | When the test subtype is `multi`, the steps of the test. | [optional] 

api/v1/datadog/docs/SyntheticsAssertionTarget.md

@@ -6,14 +6,14 @@ Name | Type | Description | Notes
 ---- | ---- | ----------- | ------
 **Operator** | [**SyntheticsAssertionOperator**](SyntheticsAssertionOperator.md) |  | 
 **Property** | Pointer to **string** | The associated assertion property. | [optional] 
-**Target** | Pointer to **interface{}** | Value used by the operator. | [optional] 
+**Target** | **interface{}** | Value used by the operator. | 
 **Type** | [**SyntheticsAssertionType**](SyntheticsAssertionType.md) |  | 
 
 ## Methods
 
 ### NewSyntheticsAssertionTarget
 
-`func NewSyntheticsAssertionTarget(operator SyntheticsAssertionOperator, type_ SyntheticsAssertionType) *SyntheticsAssertionTarget`
+`func NewSyntheticsAssertionTarget(operator SyntheticsAssertionOperator, target interface{}, type_ SyntheticsAssertionType) *SyntheticsAssertionTarget`
 
 NewSyntheticsAssertionTarget instantiates a new SyntheticsAssertionTarget object.
 This constructor will assign default values to properties that have it defined,
@@ -92,11 +92,6 @@ and a boolean to check if the value has been set.
 
 SetTarget sets Target field to given value.
 
-### HasTarget
-
-`func (o *SyntheticsAssertionTarget) HasTarget() bool`
-
-HasTarget returns a boolean if a field has been set.
 
 ### GetType
 

api/v1/datadog/docs/SyntheticsCIBatchMetadataGit.md

@@ -4,7 +4,7 @@
 
 Name | Type | Description | Notes
 ---- | ---- | ----------- | ------
-**Branch** | Pointer to **string** | The branch name. | [optional] 
+**Branch** | Pointer to **string** | Branch name. | [optional] 
 **CommitSha** | Pointer to **string** | The commit SHA. | [optional] 
 
 ## Methods

api/v1/datadog/docs/SyntheticsStepDetail.md

@@ -416,6 +416,16 @@ SetValue sets Value field to given value.
 
 HasValue returns a boolean if a field has been set.
 
+### SetValueNil
+
+`func (o *SyntheticsStepDetail) SetValueNil(b bool)`
+
+ SetValueNil sets the value for Value to be an explicit nil
+
+### UnsetValue
+`func (o *SyntheticsStepDetail) UnsetValue()`
+
+UnsetValue ensures that no value is present for Value, not even an explicit nil
 ### GetVitalsMetrics
 
 `func (o *SyntheticsStepDetail) GetVitalsMetrics() []SyntheticsCoreWebVitals`