Fix path constraints check (#1833)

* fix path constraints checking

* pre-commit fixes

Co-authored-by: ci.datadog-api-spec <[email protected]>

Author: skarimo

.generator/src/generator/templates/api.j2

@@ -251,7 +251,7 @@ func (a *{{ classname }}) {{ operation.operationId|untitle_case }}Execute(r api{
 
 	{%- for name, parameter in operation|parameters if parameter.required %}
 	{%- set schema = parameter.get("schema") %}
-	{%- set isPathParam = "*" if parameter.in == "path" else "" %}
+	{%- set isPathParam = "*" if parameter.in == "path" and not parameter.required else "" %}
 	{%- if parameter.in != "path" %}
 	if r.{{ name|variable_name}} == nil {
 		return {% if returnType %}localVarReturnValue, {% endif %}nil, {{ common_package_name }}.ReportError("{{ name|variable_name}} is required and must be specified")
@@ -268,12 +268,12 @@ func (a *{{ classname }}) {{ operation.operationId|untitle_case }}Execute(r api{
 	}
 	{%- endif %}
 	{%- if schema.minLength is defined %}
-	if strlen({{ isPathParam }}r.{{ name|variable_name}}) < {{ schema.minLength }} {
+	if datadog.Strlen({{ isPathParam }}r.{{ name|variable_name}}) < {{ schema.minLength }} {
 		return {% if returnType %}localVarReturnValue, {% endif %}nil, {{ common_package_name }}.ReportError("{{ name|variable_name}} must have at least {{ schema.minLength }} elements")
 	}
 	{%- endif %}
 	{%- if schema.maxLength is defined %}
-	if strlen({{ isPathParam }}r.{{ name|variable_name}}) > {{ schema.maxLength }} {
+	if datadog.Strlen({{ isPathParam }}r.{{ name|variable_name}}) > {{ schema.maxLength }} {
 		return {% if returnType %}localVarReturnValue, {% endif %}nil, {{ common_package_name }}.ReportError("{{ name|variable_name}} must have less than {{ schema.maxLength }} elements")
 	}
 	{%- endif %}

.generator/src/generator/templates/utils.j2

@@ -438,3 +438,8 @@ func ContainsUnparsedObject(i interface{}) (bool, interface{}) {
 	}
 	return false, nil
 }
+
+// Strlen returns number of runes in string
+func Strlen(s string) int {
+	return utf8.RuneCountInString(s)
+}

api/datadog/utils.go

@@ -9,6 +9,7 @@ import (
 	"reflect"
 	"strings"
 	"time"
+	"unicode/utf8"
 )
 
 // PtrBool is a helper routine that returns a pointer to given boolean value.
@@ -441,3 +442,8 @@ func ContainsUnparsedObject(i interface{}) (bool, interface{}) {
 	}
 	return false, nil
 }
+
+// Strlen returns number of runes in string
+func Strlen(s string) int {
+	return utf8.RuneCountInString(s)
+}