Skip to content

Add support of adaptive optimizer with DPDL #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add support of adaptive optimizer with DPDL #4

wants to merge 9 commits into from

Conversation

@Linzh7
Copy link
Collaborator

@Linzh7 Linzh7 commented Nov 1, 2024

  1. change the logic of checking if it is distributed computing from isinstance(module, (DPDDP, DDP)) to dist.get_world_size() > 1
  2. add a optim_args in the base class of DPoptimizer to enable the further customize of optimizers.

Linzh7 added 4 commits October 4, 2024 21:03
@Linzh7
feat: support adaptive optimizer in DPDL framework
3140541 
  - add optim_args in privacy_engine for optimizers with extra args
  - modify the Opacus adaptive optimizer to our AdaptDPSGD-Full version
@Linzh7
Fix a bug about a missing argument
a1b55fe
@Linzh7
Update args in both adapt DPSGD and DPSGD
9803b0f
@Linzh7
fix: ensure HPs work properly with DPDL framework
50f3568
@Linzh7 Linzh7 requested a review from ikanher November 1, 2024 10:37
@Linzh7 Linzh7 force-pushed the adaptive_optimizer branch from 1f59af5 to 1e8a50d Compare January 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikanher ikanher Awaiting requested review from ikanher

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Linzh7