Skip to content

Commit e504492

Browse files
authored
Merge pull request #28 from Cysharp/feature/nuget
chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages.
2 parents bf63aa1 + 46f4237 commit e504492

File tree

11 files changed

+15
-18
lines changed

11 files changed

+15
-18
lines changed

.github/workflows/build-main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: Cysharp/Actions/.github/actions/setup-dotnet@main
2121
- run: dotnet tool restore
2222
- run: dotnet build -c Release -p:DefineConstants=RUNNING_IN_CI
23-
- run: dotnet pack ./src/Multicaster/Multicaster.csproj -c Release --no-build -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
23+
- run: dotnet pack -c Release --no-build -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
2424
- run: dotnet retest -- -c Release --no-build
2525
- uses: Cysharp/Actions/.github/actions/upload-artifact@main
2626
with:

src/Directory.Build.props renamed to Directory.Build.props

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,14 @@
77
<LangVersion>12</LangVersion>
88

99
<SignAssembly>true</SignAssembly>
10-
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\Multicaster\opensource.snk</AssemblyOriginatorKeyFile>
11-
</PropertyGroup>
10+
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\opensource.snk</AssemblyOriginatorKeyFile>
1211

13-
<!-- Prevent local path leakage by artifacts -->
14-
<PropertyGroup>
12+
<!-- Prevent local path leakage by artifacts -->
1513
<RepoRoot>$(MSBuildThisFileDirectory)</RepoRoot>
1614
<PathMap>$(RepoRoot)=.</PathMap>
17-
</PropertyGroup>
1815

19-
<PropertyGroup>
2016
<!-- NuGet Package Information -->
17+
<IsPackable>false</IsPackable>
2118
<VersionPrefix>0.1.0</VersionPrefix>
2219
<Company>Cysharp</Company>
2320
<Authors>Cysharp</Authors>
@@ -35,8 +32,9 @@
3532
</PropertyGroup>
3633

3734
<ItemGroup>
38-
<None Include="$(MSBuildThisFileDirectory)\..\README.md" Pack="true" PackagePath="/" />
39-
<None Include="$(MSBuildThisFileDirectory)\Multicaster\Icon.png" Pack="true" PackagePath="/" />
35+
<None Include="$(MSBuildThisFileDirectory)Icon.png" Pack="true" PackagePath="\" />
36+
<None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="\" />
37+
<EmbeddedResource Include="$(MSBuildThisFileDirectory)LICENSE" />
4038
</ItemGroup>
4139

4240
<!--
File renamed without changes.
File renamed without changes.

perf/MicroBenchmark/MicroBenchmark.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
<TargetFramework>net9.0</TargetFramework>
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
7-
<IsPackable>false</IsPackable>
87
</PropertyGroup>
98

109
<ItemGroup>

src/Multicaster.Distributed.Nats/Multicaster.Distributed.Nats.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<Nullable>enable</Nullable>
66

77
<!-- NuGet -->
8+
<IsPackable>true</IsPackable>
89
<PackageId>Multicaster.Distributed.Nats</PackageId>
910
<Description>An extension package that adds NATS backend support for Multicaster.</Description>
1011

@@ -22,4 +23,4 @@
2223
<ItemGroup>
2324
<ProjectReference Include="..\Multicaster\Multicaster.csproj" />
2425
</ItemGroup>
25-
</Project>
26+
</Project>

src/Multicaster.Distributed.Redis/Multicaster.Distributed.Redis.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<Nullable>enable</Nullable>
66

77
<!-- NuGet-->
8+
<IsPackable>true</IsPackable>
89
<PackageId>Multicaster.Distributed.Redis</PackageId>
910
<Description>An extension package that adds Redis backend support for Multicaster.</Description>
1011

@@ -22,4 +23,4 @@
2223
<ItemGroup>
2324
<ProjectReference Include="..\Multicaster\Multicaster.csproj" />
2425
</ItemGroup>
25-
</Project>
26+
</Project>

src/Multicaster/Multicaster.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<Nullable>enable</Nullable>
77

88
<!-- NuGet -->
9+
<IsPackable>true</IsPackable>
910
<PackageId>Multicaster</PackageId>
1011
<Description>Provides a proxy for transparently invoking methods of multiple POCO instances or remote clients through an interface.</Description>
1112

test/Multicaster.Distributed.Nats.Tests/Multicaster.Distributed.Nats.Tests.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<TargetFramework>net8.0</TargetFramework>
44
<ImplicitUsings>enable</ImplicitUsings>
55
<Nullable>enable</Nullable>
6-
<IsPackable>false</IsPackable>
76
<IsTestProject>true</IsTestProject>
87
</PropertyGroup>
98
<ItemGroup>
@@ -25,4 +24,4 @@
2524
<ItemGroup>
2625
<Using Include="Xunit" />
2726
</ItemGroup>
28-
</Project>
27+
</Project>

test/Multicaster.Distributed.Redis.Tests/Multicaster.Distributed.Redis.Tests.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<TargetFramework>net8.0</TargetFramework>
44
<ImplicitUsings>enable</ImplicitUsings>
55
<Nullable>enable</Nullable>
6-
<IsPackable>false</IsPackable>
76
<IsTestProject>true</IsTestProject>
87
</PropertyGroup>
98
<ItemGroup>
@@ -25,4 +24,4 @@
2524
<ItemGroup>
2625
<Using Include="Xunit" />
2726
</ItemGroup>
28-
</Project>
27+
</Project>

0 commit comments

Comments
 (0)