Update ContainerHasAspireEnvironmentVariables to evaluate final env vars.

Author: afscrome

tests/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.Tests/ResourceCreationTests.cs

@@ -1,16 +1,16 @@
+using Aspire.Components.Common.Tests;
 using Aspire.Hosting;
 using Aspire.Hosting.Utils;
-using Microsoft.Extensions.FileProviders;
-using Microsoft.Extensions.Hosting;
+using Xunit.Abstractions;
 
 namespace CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.Tests;
 
-public class ResourceCreationTests
+public class ResourceCreationTests(ITestOutputHelper testOutputHelper)
 {
     [Fact]
     public void CanCreateTheCollectorResource()
     {
-        var builder = DistributedApplication.CreateBuilder();
+        var builder = TestDistributedApplicationBuilder.Create();
 
         builder.AddOpenTelemetryCollector("collector")
             .WithConfig("./config.yaml")
@@ -150,33 +150,33 @@ public void CanDisableBothEndpoints()
     }
 
     [Fact]
-    public void ContainerHasAspireEnvironmentVariables()
+    [RequiresDocker]
+    public async Task ContainerHasAspireEnvironmentVariables()
     {
-        var builder = DistributedApplication.CreateBuilder();
+        using var builder = TestDistributedApplicationBuilder.Create()
+            .WithTestAndResourceLogging(testOutputHelper);
+        builder.Configuration["APPHOST:ContainerHostname"] = "what.ever";
 
-        builder.AddOpenTelemetryCollector("collector")
+        var collector = builder.AddOpenTelemetryCollector("collector")
             .WithAppForwarding();
 
         using var app = builder.Build();
         var appModel = app.Services.GetRequiredService<DistributedApplicationModel>();
-        var collectorResource = appModel.Resources.OfType<OpenTelemetryCollectorResource>().SingleOrDefault();
-        Assert.NotNull(collectorResource);
 
-        var envs = collectorResource.Annotations.OfType<EnvironmentCallbackAnnotation>().ToList();
-        Assert.NotEmpty(envs);
+        var resourceNotificationService = app.Services.GetRequiredService<ResourceNotificationService>();
 
-        var context = new EnvironmentCallbackContext(new DistributedApplicationExecutionContext(new DistributedApplicationExecutionContextOptions(DistributedApplicationOperation.Run)));
-        foreach (var env in envs)
-        {
-            env.Callback(context);
-        }
+        await app.StartAsync();
+        await resourceNotificationService.WaitForResourceHealthyAsync(collector.Resource.Name);
+
+        Assert.True(resourceNotificationService.TryGetCurrentState(collector.Resource.Name, out var resourceEvent));
+
+        var envVars = resourceEvent.Snapshot.EnvironmentVariables.ToDictionary(k => k.Name, v => v.Value);
 
-        Assert.Contains("ASPIRE_ENDPOINT", context.EnvironmentVariables.Keys);
-        Assert.Contains("ASPIRE_API_KEY", context.EnvironmentVariables.Keys);
+        var endpoint = Assert.Contains("ASPIRE_ENDPOINT", envVars);
+        var apiKey = Assert.Contains("ASPIRE_API_KEY", envVars);
 
-        var url = Assert.IsType<HostUrl>(context.EnvironmentVariables["ASPIRE_ENDPOINT"]);
-        Assert.Equal("http://localhost:18889", url.Url);
-        Assert.NotNull(context.EnvironmentVariables["ASPIRE_API_KEY"]);
+        Assert.Equal($"http://what.ever:18889", endpoint);
+        Assert.NotNull(apiKey);
     }
 
     [Fact]