Fix settings

Author: Mariusz08

forum/qa-plugin/send-pw-on-register/qa-pw-admin.php

@@ -5,22 +5,39 @@ class qa_pw_admin
     public function admin_form(&$qa_content)
     {
         $isSaved = false;
-
+        $info = null;
+		
         if (qa_clicked('sendPwMessageOnRegister_save')) {
-            qa_opt('sendPwMessageOnRegister_messageContent', qa_post_text('messageContent'));
-            qa_opt('sendPwMessageOnRegister_enabled', qa_post_text('enablePlugin'));
-            qa_opt('sendPwMessageOnRegister_botId', qa_post_text('botId'));
-            
-            $isSaved = true;
+            $canSave = (bool) qa_post_text('enablePlugin');
+            if (empty(qa_post_text('messageContent'))) {
+                $canSave = false;
+                $info = 'Empty message content';
+            }
+			
+            require_once QA_INCLUDE_DIR . 'db/users.php';
+			
+            if ([] === qa_db_user_get_userid_handles(qa_post_text('botId'))) {
+                $canSave = false;
+                $info = 'Invalid bot id';
+            }
+
+            if ($canSave) {
+                qa_opt('sendPwMessageOnRegister_messageContent', qa_post_text('messageContent'));
+                qa_opt('sendPwMessageOnRegister_enabled', qa_post_text('enablePlugin'));
+                qa_opt('sendPwMessageOnRegister_botId', qa_post_text('botId'));
+                $isSaved = true;
+            } else {
+                qa_opt('sendPwMessageOnRegister_enabled', false);
+            }
         }
 
-        return $this->prepareAdminForm($isSaved);
+        return $this->prepareAdminForm($isSaved, $info);
     }
 
-    private function prepareAdminForm($isSaved)
+    private function prepareAdminForm($isSaved, $info)
     {
         return [
-            'ok' => $isSaved ? 'Settings saved' : null,
+            'ok' => $isSaved ? 'Settings saved' : $info,
             'fields' => [
                 [
                     'label' => 'Enable plugin',

forum/qa-plugin/send-pw-on-register/qa-pw-event.php

@@ -10,21 +10,25 @@ public function process_event($event, $userId, $handle, $cookieId, $params)
 
             $botId = qa_opt('sendPwMessageOnRegister_botId');
             $messageContent = qa_opt('sendPwMessageOnRegister_messageContent');
-                
+            
+            if (empty($botId) || empty($messageContent)) {
+                return;
+            }
+			
             $messsageId = qa_db_message_create(
                 $botId,
                 $userId,
                 $messageContent,
-                ''
+                '',
+				false
             );
 
             $fromUserHandle = qa_db_query_sub('SELECT `handle` FROM ^users WHERE `userid` = #', $botId);
-            $toUserHandle = qa_db_query_sub('SELECT `handle` FROM ^users WHERE `userid` = #', $userId);
-                
+            
             qa_report_event('u_message', $botId, $fromUserHandle, qa_cookie_get(), [
                 'userid' => $userId,
-                'handle' => $toUserHandle,
-                'messageid' => $messageId,
+                'handle' => $handle,
+                'messageid' => (int) $messageId,
                 'message' => $messageContent
             ]);
         }