release: fixes

- Fix variable mismatch in the install category function.

Author: Soare-Robert-Daniel

src/Modules/Script_loader.php

@@ -186,7 +186,7 @@ public function get_survey_common_data( $reference_data = array() ) {
 		) {
 			$common_data['attributes']['days_since_install'] = $this->install_time_category( $reference_data['attributes']['install_days_number'] );
 		}
-	
+
 		return $common_data;
 	}
 
@@ -198,19 +198,23 @@ public function get_survey_common_data( $reference_data = array() ) {
 	 * @return int The category.
 	 */
 	private function install_time_category( $install_days_number ) {
-		$install_category = 0;
-
 		if ( 1 < $install_days_number && 8 > $install_days_number ) {
-			$install_category = 7;
-		} elseif ( 8 <= $install_days_number && 31 > $install_days_number ) {
-			$install_days_number = 30;
-		} elseif ( 30 < $install_days_number && 90 > $install_days_number ) {
-			$install_category = 90;
-		} elseif ( 90 <= $install_days_number ) {
-			$install_category = 91;
+			return 7;
+		}
+		
+		if ( 8 <= $install_days_number && 31 > $install_days_number ) {
+			return 30;
+		}
+		
+		if ( 30 < $install_days_number && 90 > $install_days_number ) {
+			return 90;
+		}
+		
+		if ( 90 <= $install_days_number ) {
+			return 91;
 		}
 
-		return $install_category;
+		return 0;
 	}
 
 	/**

tests/script-loader-test.php

@@ -241,4 +241,40 @@ public function test_secret_masking() {
 		$this->assertEquals( null, $script_loader->secret_masking( null ) );
 		$this->assertEquals( [], $script_loader->secret_masking( [] ) );
 	}
+
+	/**
+	 * Test the install_time_category method for all cases.
+	 * 
+	 * @return void 
+	 */
+	public function test_install_time_category() {
+		$script_loader = new \ThemeisleSDK\Modules\Script_Loader();
+
+		$test_data = [
+			// Test default case (0-1 days)
+			0   => 0,
+			1   => 0,
+			// Test 1-7 days category
+			2   => 7,
+			5   => 7,
+			7   => 7,
+			// Test 8-30 days category
+			8   => 30,
+			15  => 30,
+			30  => 30,
+			// Test 31-89 days category
+			31  => 90,
+			45  => 90,
+			89  => 90,
+			// Test 90+ days category
+			90  => 91,
+			100 => 91,
+			365 => 91,
+		];
+
+		foreach ( $test_data as $days => $expected ) {
+			$data = $script_loader->get_survey_common_data( [ 'attributes' => [ 'install_days_number' => $days ] ] );
+			$this->assertEquals( $expected, $data['attributes']['days_since_install'], "Failed asserting that {$days} days maps to category {$expected}" );
+		}
+	}
 }