fix: run cp with bash to expand glob patterns

Author: not-matthias

src/run/runner/helpers/apt.rs

@@ -155,12 +155,20 @@ fn restore_from_cache(system_info: &SystemInfo, cache_dir: &Path) -> Result<()>
         .to_str()
         .ok_or_else(|| anyhow!("Invalid cache directory path"))?;
 
-    run_with_sudo("cp", ["-r", &format!("{cache_dir_str}/*"), "/"])?;
+    copy_files_recursively(cache_dir_str, "/")?;
 
     debug!("Cache restored successfully");
     Ok(())
 }
 
+fn copy_files_recursively(src: &str, dst: &str) -> Result<()> {
+    // IMPORTANT: We have to use 'bash' here to ensure that glob patterns are expanded correctly
+    let copy_cmd = format!("cp -r {src}/* {dst}");
+    run_with_sudo("bash", ["-c", &copy_cmd])?;
+
+    Ok(())
+}
+
 /// Save installed packages to the cache directory
 fn save_to_cache(system_info: &SystemInfo, cache_dir: &Path, packages: &[&str]) -> Result<()> {
     if !is_system_compatible(system_info) {
@@ -225,3 +233,29 @@ fn save_to_cache(system_info: &SystemInfo, cache_dir: &Path, packages: &[&str])
     debug!("Packages cached successfully");
     Ok(())
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use std::fs;
+    use tempfile::TempDir;
+
+    #[test]
+    fn test_copy_files_recursively() {
+        let src = TempDir::new().unwrap();
+        fs::write(src.path().join("file1.txt"), "content1").unwrap();
+        fs::write(src.path().join("file2.txt"), "content2").unwrap();
+
+        let dst = TempDir::new().unwrap();
+        copy_files_recursively(src.path().to_str().unwrap(), dst.path().to_str().unwrap()).unwrap();
+
+        assert_eq!(
+            fs::read_to_string(dst.path().join("file1.txt")).unwrap(),
+            "content1"
+        );
+        assert_eq!(
+            fs::read_to_string(dst.path().join("file2.txt")).unwrap(),
+            "content2"
+        );
+    }
+}