Merge pull request #1619 from CitiesSkylinesMods/bugfix/1612-infinite-loop-traversing-node-segments

Infinite loop while traversing segments of node

Author: krzychu124

TLM/TLM/Util/Iterators/GetNodeSegmentIdsEnumerator.cs

@@ -17,6 +17,7 @@ public struct GetNodeSegmentIdsEnumerator : IEnumerator<ushort> {
 
         private bool firstRun;
         private ushort currentSegmentId;
+        private int watchdog;
 
         public GetNodeSegmentIdsEnumerator(ushort nodeId, ushort initialSegmentId, ClockDirection clockDirection, NetSegment[] segmentBuffer) {
             this.nodeId = nodeId;
@@ -26,6 +27,7 @@ public GetNodeSegmentIdsEnumerator(ushort nodeId, ushort initialSegmentId, Clock
 
             this.firstRun = true;
             this.currentSegmentId = default;
+            this.watchdog = 0;
         }
 
         public ushort Current => currentSegmentId;
@@ -38,6 +40,7 @@ public bool MoveNext() {
             } else if (firstRun && initialSegment != 0) {
                 currentSegmentId = initialSegment;
                 firstRun = false;
+                watchdog++;
                 return true;
             }
 
@@ -49,7 +52,7 @@ public bool MoveNext() {
                 throw new Exception($"Unknown ClockDirection '{nameof(clockDirection)}'");
             }
 
-            if (currentSegmentId == 0 || currentSegmentId == initialSegment) {
+            if (currentSegmentId == 0 || currentSegmentId == initialSegment || ++watchdog == Constants.MAX_SEGMENTS_OF_NODE) {
                 return false;
             }