chore: Integrate scale package into runtime (#1824)

* revise APIItems

* update scale integration for version

* rm lib/runtime/extrinsic

* lib/runtime/life updates

* update wasmer

* wip

* update skipped test

* cr feedback, fixed storageAppend

* update test

Author: timwu20

dot/core/service_test.go

@@ -33,12 +33,12 @@ import (
 	"github.com/ChainSafe/gossamer/lib/common"
 	"github.com/ChainSafe/gossamer/lib/keystore"
 	"github.com/ChainSafe/gossamer/lib/runtime"
-	"github.com/ChainSafe/gossamer/lib/runtime/extrinsic"
 	runtimemocks "github.com/ChainSafe/gossamer/lib/runtime/mocks"
 	"github.com/ChainSafe/gossamer/lib/runtime/storage"
 	"github.com/ChainSafe/gossamer/lib/runtime/wasmer"
 	"github.com/ChainSafe/gossamer/lib/transaction"
 	"github.com/ChainSafe/gossamer/lib/trie"
+	"github.com/ChainSafe/gossamer/pkg/scale"
 	log "github.com/ChainSafe/log15"
 	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
@@ -287,9 +287,10 @@ func TestHandleChainReorg_WithReorg_Transactions(t *testing.T) {
 	addTestBlocksToState(t, height, s.blockState.(*state.BlockState))
 
 	// create extrinsic
-	ext := extrinsic.NewIncludeDataExt([]byte("nootwashere"))
-	tx, err := ext.Encode()
+	enc, err := scale.Marshal([]byte("nootwashere"))
 	require.NoError(t, err)
+	// we prefix with []byte{2} here since that's the enum index for the old IncludeDataExt extrinsic
+	tx := append([]byte{2}, enc...)
 
 	bhash := s.blockState.BestBlockHash()
 	rt, err := s.blockState.GetRuntime(&bhash)

dot/rpc/modules/api_mocks.go

@@ -56,8 +56,8 @@ func NewMockCoreAPI() *modulesmocks.MockCoreAPI {
 }
 
 // NewMockVersion creates and returns an runtime Version interface mock
-func NewMockVersion() *runtimemocks.MockVersion {
-	m := new(runtimemocks.MockVersion)
+func NewMockVersion() *runtimemocks.Version {
+	m := new(runtimemocks.Version)
 	m.On("SpecName").Return([]byte(`mock-spec`))
 	m.On("ImplName").Return(nil)
 	m.On("AuthoringVersion").Return(uint32(0))

dot/rpc/modules/state.go

@@ -443,7 +443,7 @@ func (*StateModule) SubscribeStorage(_ *http.Request, _ *StateStorageQueryRangeR
 }
 
 // ConvertAPIs runtime.APIItems to []interface
-func ConvertAPIs(in []*runtime.APIItem) []interface{} {
+func ConvertAPIs(in []runtime.APIItem) []interface{} {
 	ret := make([]interface{}, 0)
 	for _, item := range in {
 		encStr := hex.EncodeToString(item.Name[:])

dot/state/block_notify_test.go

@@ -182,8 +182,8 @@ func TestService_RegisterUnRegisterConcurrentCalls(t *testing.T) {
 }
 
 // NewMockVersion creates and returns an runtime Version interface mock
-func NewMockVersion(specVer uint32) *runtimemocks.MockVersion {
-	m := new(runtimemocks.MockVersion)
+func NewMockVersion(specVer uint32) *runtimemocks.Version {
+	m := new(runtimemocks.Version)
 	m.On("SpecName").Return([]byte(`mock-spec`))
 	m.On("ImplName").Return(nil)
 	m.On("AuthoringVersion").Return(uint32(0))