fixup! sqlite: restore changes from nodejs#55373

Author: Ceres6

lib/internal/test_runner/snapshot.js

@@ -77,7 +77,7 @@ class SnapshotFile {
   }
 
   setSnapshot(id, value) {
-    this.snapshots[keyEscape(id)] = value;
+    this.snapshots[escapeSnapshotKey(id)] = value;
   }
 
   nextId(name) {
@@ -290,7 +290,7 @@ function validateFunctionArray(fns, name) {
   }
 }
 
-function keyEscape(str) {
+function escapeSnapshotKey(str) {
   let result = JSONStringify(str, null, 2).slice(1, -1);
   result = StringPrototypeReplaceAll(result, '`', '\\`');
   result = StringPrototypeReplaceAll(result, '${', '\\${');

test/fixtures/test-runner/snapshots/special-character.js

@@ -0,0 +1,14 @@
+'use strict';
+const { test } = require('node:test');
+
+test('\r', (t) => {
+  t.assert.snapshot({ key: 'value' });
+});
+
+test(String.fromCharCode(55296), t => {
+	t.assert.snapshot({key: 'value'});
+});
+
+test(String.fromCharCode(57343), t => {
+	t.assert.snapshot({key: 'value'});
+});

test/fixtures/test-runner/snapshots/special-character.js.snapshot

@@ -0,0 +1,17 @@
+exports[`\r 1`] = `
+{
+  "key": "value"
+}
+`;
+
+exports[`\ud800 1`] = `
+{
+  "key": "value"
+}
+`;
+
+exports[`\udfff 1`] = `
+{
+  "key": "value"
+}
+`;

test/parallel/test-runner-snapshot-tests.js

@@ -342,6 +342,30 @@ test('t.assert.snapshot()', async (t) => {
   });
 });
 
+test('special characters are allowed', async (t) => {
+  const fixture = fixtures.path(
+    'test-runner', 'snapshots', 'special-character.js'
+  );
+
+  await common.spawnPromisified(
+    process.execPath,
+    ['--test-update-snapshots', fixture],
+    { cwd: tmpdir.path },
+  );
+
+  const child = await common.spawnPromisified(
+    process.execPath,
+    [fixture],
+    { cwd: tmpdir.path },
+  );
+
+  t.assert.strictEqual(child.code, 0);
+  t.assert.strictEqual(child.signal, null);
+  t.assert.match(child.stdout, /tests 3/);
+  t.assert.match(child.stdout, /pass 3/);
+  t.assert.match(child.stdout, /fail 0/);
+});
+
 test('snapshots from multiple files (isolation=none)', async (t) => {
   tmpdir.refresh();