Merge pull request #115 from COMP1010UNSW/maddy-fix-empty-para

MaddyGuthridge · web-flow · commit 1171571392e8 · 2025-04-06T21:34:17.000+10:00
Fix crash when rendering a paragraph with an empty string
diff --git a/pyhtml/__tag_base.py b/pyhtml/__tag_base.py
@@ -172,18 +172,20 @@ def _render(
         else:
             opening += ">"
 
-        if not len(self.children):
+        # Render children
+        indent_increase = options.indent if options.spacing == "\n" else ""
+        children = util.render_children(
+            self.children,
+            self._escape_children(),
+            "" if indent_increase is None else indent + indent_increase,
+            options,
+        )
+
+        # If rendering the children produced no output
+        if not len(children):
             opening += f"</{self._get_tag_name()}>"
             return [opening]
         else:
-            indent_increase = options.indent if options.spacing == "\n" else ""
-            # Children
-            children = util.render_children(
-                self.children,
-                self._escape_children(),
-                "" if indent_increase is None else indent + indent_increase,
-                options,
-            )
             closing = f"</{self._get_tag_name()}>"
             if options.spacing == "\n":
                 return [
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "pyhtml-enhanced"
-version = "2.2.3"
+version = "2.2.4"
 description = "A library for building HTML documents with a simple and learnable syntax"
 readme = "README.md"
 license = "MIT"
diff --git a/tests/basic_rendering_test.py b/tests/basic_rendering_test.py
@@ -343,3 +343,12 @@ def test_whitespace_sensitive_with_attrs():
     Do whitespace-sensitive tags render properly when they have attributes?
     """
     assert str(pre(test="test")("hi")) == '<pre test="test">hi</pre>'
+
+
+def test_render_ele_with_empty_str():
+    """
+    Rendering an element with an empty string used to cause a crash. Add a
+    test so we avoid it.
+    """
+    doc = body("")
+    assert str(doc) == "<body></body>"
diff --git a/tests/render_options_test.py b/tests/render_options_test.py
@@ -161,3 +161,12 @@ def test_paragraphs_render_in_body():
             "</body>",
         ]
     )
+
+
+def test_render_paragraph_with_empty_str():
+    """
+    Rendering a paragraph with an empty string used to cause a crash. Add a
+    test so we avoid it.
+    """
+    doc = p.p("")
+    assert str(doc) == "<p></p>"

Original file line number	Diff line number	Diff line change
`@@ -161,3 +161,12 @@ def test_paragraphs_render_in_body():`
`161`	`161`	`"</body>",`
`162`	`162`	`]`
`163`	`163`	`)`
	`164`	`+`
	`165`	`+`
	`166`	`+def test_render_paragraph_with_empty_str():`
	`167`	`+ """`
	`168`	`+ Rendering a paragraph with an empty string used to cause a crash. Add a`
	`169`	`+ test so we avoid it.`
	`170`	`+ """`
	`171`	`+ doc = p.p("")`
	`172`	`+ assert str(doc) == "<p></p>"`