Skip to content

Commit a706e36

Browse files
committed
fix: solidjs external in tsup.
1 parent b5c4d9f commit a706e36

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

.changeset/shaggy-cars-destroy.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'vike-metadata-solid': patch
3+
---
4+
5+
fix: solidjs external tsup.

packages/solid/package.json

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,7 @@
5656
},
5757
"browser": {},
5858
"exports": {
59-
"solid": {
60-
"development": "./dist/dev.jsx",
61-
"import": "./dist/index.jsx"
62-
},
63-
"development": {
64-
"import": {
65-
"types": "./dist/index.d.ts",
66-
"default": "./dist/dev.js"
67-
}
68-
},
59+
"solid": "./dist/index.jsx",
6960
"import": {
7061
"types": "./dist/index.d.ts",
7162
"default": "./dist/index.js"

packages/solid/src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ export type UseMetadataFunctionType = ((params: UseMetadataParams) => void) & {
232232
* Recommended way to set default values.
233233
*
234234
* @example
235-
* import { useMetadata } from 'vike-metadata-vue';
235+
* import { useMetadata } from 'vike-metadata-solid';
236236
*
237237
* useMetadata.setGlobalDefaults({
238238
* title: 'Home | Solid Launch',

packages/solid/tsup.config.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,15 @@ const preset_options: preset.PresetOptions = {
99
// entries with '.tsx' extension will have `solid` export condition generated
1010
entry: 'src/index.tsx',
1111
// will generate a separate development entry
12-
dev_entry: true,
12+
dev_entry: false,
1313
},
1414
],
1515
// Set to `true` to remove all `console.*` calls and `debugger` statements in prod builds
1616
drop_console: true,
1717
// Set to `true` to generate a CommonJS build alongside ESM
1818
// cjs: true,
1919
modify_esbuild_options: (esbuildOptions) => {
20-
esbuildOptions.platform = 'node';
21-
esbuildOptions.external?.push('vike-solid');
22-
esbuildOptions.external?.push('vike');
20+
esbuildOptions.external = ['vike', 'vike-solid'];
2321
esbuildOptions.minify = true; // from 21kb to 10.97kb
2422
// esbuildOptions.minify = 'terser', // from 21kb to 10.99kb
2523
return esbuildOptions;

0 commit comments

Comments
 (0)