Update to NET 8 (#5033)

* net8

* WAM fix

* test fix

* platform proxy

* more fixes

* 1

* net8

* WAM fix

* test fix

* platform proxy

* more fixes

---------

Co-authored-by: Gladwin Johnson <[email protected]>
Co-authored-by: Bogdan Gavril <[email protected]>

Author: 3 people

CONTRIBUTING.md

@@ -137,7 +137,7 @@ Have a feature request for MSAL? Complete a [Feature request](https://github.com
 ### Visual Studio
 
 Use the latest Visual Studio. It will guide you on the components needed to be installed. 
-For MAUI, edit the .csproj and enable the MAUI targets.
+For MAUI, edit the .csproj and enable the mobile targets.
 
 ### Package
 

build/pipeline-perf-tests-automation.yaml

@@ -16,7 +16,7 @@ pool:
 variables:
   BuildPlatform: 'any cpu'
   BuildConfiguration: 'release'
-  BuildRuntime: 'net6.0'
+  BuildRuntime: 'net8.0'
 
 jobs:
   - job: 'BuildJob'
@@ -28,9 +28,9 @@ jobs:
         versionSpec: 6.x
 
     - task: UseDotNet@2
-      displayName: 'Use the latest .NET 6'
+      displayName: 'Use the latest .NET 8'
       inputs:
-        version: 6.x
+        version: 8.x
 
     - task: NuGetCommand@2
       displayName: 'NuGet restore'

build/platform_and_feature_flags.props

@@ -1,29 +1,29 @@
 <Project>
-  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetCore)' or '$(TargetFramework)' == '$(TargetFrameworkNet6)'">
+  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetCore)' or '$(TargetFramework)' == '$(TargetFrameworkNet)'">
     <DefineConstants>$(DefineConstants);NET_CORE;SUPPORTS_CONFIDENTIAL_CLIENT;SUPPORTS_CUSTOM_CACHE;SUPPORTS_BROKER;SUPPORTS_WIN32;</DefineConstants>
   </PropertyGroup>
-  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet6)'" >
+  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet)'" >
     <DefineConstants>$(DefineConstants);SUPPORTS_SYSTEM_TEXT_JSON</DefineConstants>
   </PropertyGroup>
-  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet6)' or '$(TargetFramework)' == '$(TargetFrameworkNetDesktop462)' or '$(TargetFramework)' == '$(TargetFrameworkNetDesktop472)' or '$(TargetFramework)' == '$(TargetFrameworkNetStandard)'">
+  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet)' or '$(TargetFramework)' == '$(TargetFrameworkNetDesktop462)' or '$(TargetFramework)' == '$(TargetFrameworkNetDesktop472)' or '$(TargetFramework)' == '$(TargetFrameworkNetStandard)'">
     <DefineConstants>$(DefineConstants);SUPPORTS_OTEL;</DefineConstants>
   </PropertyGroup>
-  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet6)' or '$(TargetFramework)' == '$(TargetFrameworkNetDesktop472)'">
+  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet)' or '$(TargetFramework)' == '$(TargetFrameworkNetDesktop472)'">
     <DefineConstants>$(DefineConstants);SUPPORTS_MTLS;</DefineConstants>
   </PropertyGroup>
-  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet6Android)'">
+  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetAndroid)'">
     <DefineConstants>$(DefineConstants);ANDROID;SUPPORTS_BROKER</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetDesktop462)' or '$(TargetFramework)' == '$(TargetFrameworkNetDesktop472)'">
     <DefineConstants>$(DefineConstants);SUPPORTS_BROKER;SUPPORTS_CONFIDENTIAL_CLIENT;SUPPORTS_CUSTOM_CACHE;SUPPORTS_WIN32</DefineConstants>
   </PropertyGroup>
-  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet6Ios)'">
+  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetIos)'">
     <DefineConstants>$(DefineConstants);iOS;SUPPORTS_BROKER</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetStandard)'">
     <DefineConstants>$(DefineConstants);NETSTANDARD;SUPPORTS_CONFIDENTIAL_CLIENT;SUPPORTS_BROKER;SUPPORTS_CUSTOM_CACHE;SUPPORTS_WIN32;</DefineConstants>
   </PropertyGroup>
-  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNet6Android)' or '$(TargetFramework)' == '$(TargetFrameworkNet6Ios)'">
+  <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetAndroid)' or '$(TargetFramework)' == '$(TargetFrameworkNetIos)'">
     <DefineConstants>$(DefineConstants);MOBILE</DefineConstants>
   </PropertyGroup>
 </Project>

build/template-OneBranch-CI-libsandsamples.yaml

@@ -18,9 +18,9 @@ steps:
 
 # Use the latest .NET SDK
 - task: UseDotNet@2
-  displayName: 'Use .Net Core sdk 6.x'
+  displayName: 'Use .Net Core sdk 8.x'
   inputs:
-    version: 6.x
+    version: 8.x
 
 # Compute the source directory based on the parameter MsalSourceDir
 - task: PowerShell@2

build/template-build-and-prep-automation.yaml

@@ -6,9 +6,9 @@ steps:
     versionSpec: 6.x
 
 - task: UseDotNet@2
-  displayName: 'Use the latest .NET 6'
+  displayName: 'Use the latest .NET 8'
   inputs:
-    version: 6.x
+    version: 8.x
 
 # Nuget Restore and Build 
 - template: template-restore-build-libsandsamples.yaml
@@ -78,7 +78,7 @@ steps:
         #dev apps to check
         $AppsToCheck = @('MSIX\WPF\bin\Release\', 
                          'MSIX\WPF.Package\bin\AnyCPU\Release\WPF\', 
-                         'NetCoreWinFormsWam\bin\Release\net6.0-windows10.0.17763.0\', 
+                         'NetCoreWinFormsWam\bin\Release\net8.0-windows10.0.17763.0\', 
                          'NetDesktopWpf\bin\Release\', 
                          'NetFrameworkWam\bin\Release\',                        
                          'WAMClassLibrary\bin\Release\',

build/template-desktop-unit-and-automation.yaml

@@ -1,8 +1,8 @@
 steps:
 - task: UseDotNet@2
-  displayName: 'Use the latest .NET 6'
+  displayName: 'Use the latest .NET 8'
   inputs:
-    version: 6.x
+    version: 8.x
 
 - task: DownloadPipelineArtifact@2
   displayName: 'Download Drop'

build/template-pack-and-sign-packages.yaml

@@ -18,9 +18,9 @@ steps:
 
 # Use the latest .NET SDK
 - task: UseDotNet@2
-  displayName: 'Use the latest .NET 6'
+  displayName: 'Use the latest .NET 8'
   inputs:
-    version: 6.x
+    version: 8.x
 
 - task: Bash@3
   displayName: Install MAUI

build/template-prebuild-code-analysis.yaml

@@ -8,9 +8,9 @@ steps:
     versionSpec: '16.x'
 
 - task: UseDotNet@2
-  displayName: 'Use the latest .NET 6'
+  displayName: 'Use the latest .NET 8'
   inputs:
-    version: 6.x
+    version: 8.x
 
 - task: securedevelopmentteam.vss-secure-development-tools.build-task-policheck.PoliCheck@2
   displayName: 'Run PoliCheck'

build/template-run-unit-tests.yaml

@@ -7,7 +7,7 @@ parameters:
 steps:
 
 - task: VSTest@2
-  displayName: 'Run unit tests (.NET FX)'
+  displayName: 'Run unit tests NetFwk (vanilla CI)'
   condition: and(succeeded(), eq(variables['PipelineType'], 'legacy'))
   inputs:
     testSelector: 'testAssemblies'
@@ -20,7 +20,7 @@ steps:
     pathtoCustomTestAdapters: 'C:\temp' # Workaround for test failure, as NUnit Test Adapter that gets detected seems to mess something up
 
 - task: VSTest@2
-  displayName: 'Run unit tests (.NET FX) on OneBranch'
+  displayName: 'Run unit tests NetFwk on OneBranch'
   condition: and(succeeded(), eq(variables['PipelineType'], 'OneBranch'))
   inputs:
     testSelector: 'testAssemblies'
@@ -32,10 +32,10 @@ steps:
     minimumExpectedTests: '1'
 
 - task: VSTest@2
-  displayName: 'Run unit tests (.NET 6)'
+  displayName: 'Run unit tests .NET '
   inputs:
     testSelector: 'testAssemblies'
-    testAssemblyVer2: '**\Microsoft.Identity.Test.Unit\bin\**\net6.0\Microsoft.Identity.Test.Unit.dll'
+    testAssemblyVer2: '**\Microsoft.Identity.Test.Unit\bin\**\net8.0\Microsoft.Identity.Test.Unit.dll'
     searchFolder: '$(System.DefaultWorkingDirectory)'
     runInParallel: true
     codeCoverageEnabled: true

global.json

@@ -1,6 +1,6 @@
 {
     "sdk": {
-        "version": "6.0.428",
+        "version": "8.0.404",
         "rollForward": "latestFeature"
     }
 }