Avoid returning internal information for extensible resource snapshot (#18119)

Closes #18110
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/18119)

Author: anthony-c-martin

src/Bicep.Cli.IntegrationTests/Files/SnapshotCommandTests/extensibility/bicepconfig.json

@@ -0,0 +1,5 @@
+{
+  "extensions": {
+    "http": "br:example.azurecr.io/extensions/snapshot:1.2.3"
+  }
+}

src/Bicep.Cli.IntegrationTests/Files/SnapshotCommandTests/extensibility/main.bicep

@@ -0,0 +1,18 @@
+extension http
+
+param coords {
+  latitude: string
+  longitude: string
+}
+
+resource gridpointsReq 'request@v1' = {
+  uri: 'https://api.weather.gov/points/${coords.latitude},${coords.longitude}'
+  format: 'raw'
+}
+
+var gridpoints = json(gridpointsReq.body).properties
+
+resource forecastReq 'request@v1' = {
+  uri: 'https://api.weather.gov/gridpoints/${gridpoints.gridId}/${gridpoints.gridX},${gridpoints.gridY}/forecast'
+  format: 'raw'
+}

src/Bicep.Cli.IntegrationTests/Files/SnapshotCommandTests/extensibility/main.bicepparam

@@ -0,0 +1,6 @@
+using 'main.bicep'
+
+param coords = {
+  latitude: '47.6363726'
+  longitude: '-122.1357068'
+}

src/Bicep.Cli.IntegrationTests/Files/SnapshotCommandTests/extensibility/main.snapshot.json

@@ -0,0 +1,19 @@
+{
+  "predictedResources": [
+    {
+      "properties": {
+        "uri": "https://api.weather.gov/points/47.6363726,-122.1357068",
+        "format": "raw"
+      },
+      "type": "request@v1"
+    },
+    {
+      "properties": {
+        "uri": "[format('https://api.weather.gov/gridpoints/{0}/{1},{2}/forecast', json(reference('gridpointsReq').body).properties.gridId, json(reference('gridpointsReq').body).properties.gridX, json(reference('gridpointsReq').body).properties.gridY)]",
+        "format": "raw"
+      },
+      "type": "request@v1"
+    }
+  ],
+  "diagnostics": []
+}

src/Bicep.Cli.IntegrationTests/SnapshotCommandTests.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+using System.IO.Abstractions.TestingHelpers;
 using System.Reflection;
 using System.Text.RegularExpressions;
 using Azure;
@@ -9,13 +10,15 @@
 using Bicep.Cli.Models;
 using Bicep.Cli.UnitTests.Assertions;
 using Bicep.Core.Configuration;
+using Bicep.Core.FileSystem;
 using Bicep.Core.Registry;
 using Bicep.Core.Samples;
 using Bicep.Core.UnitTests;
 using Bicep.Core.UnitTests.Assertions;
 using Bicep.Core.UnitTests.Baselines;
 using Bicep.Core.UnitTests.Mock;
 using Bicep.Core.UnitTests.Utils;
+using Bicep.IO.FileSystem;
 using FluentAssertions;
 using FluentAssertions.Execution;
 using Microsoft.CodeAnalysis.Sarif;
@@ -125,13 +128,18 @@ public async Task Snapshot_with_overwrite_should_generate_a_valid_snapshot_file(
     [TestCategory(BaselineHelper.BaselineTestCategory)]
     public async Task Snapshot_generates_correct_format(EmbeddedFile paramFile)
     {
+        var services = await ExtensionTestHelper.GetServiceBuilderWithPublishedExtension(ExtensionResourceTypeHelper.GetHttpExtensionTypesTgz(), new(), artifactTarget: "example.azurecr.io/extensions/snapshot:1.2.3");
+        var clientFactory = services.Build().Construct<IContainerRegistryClientFactory>();
+
         var subscriptionId = new Guid().ToString();
         var resourceGroupName = "myRg";
 
         var baselineFolder = BaselineFolder.BuildOutputFolder(TestContext, paramFile);
         var snapshotFile = baselineFolder.GetFileOrEnsureCheckedIn("main.snapshot.json");
 
-        var result = await Bicep("snapshot", baselineFolder.EntryFile.OutputFilePath, "--mode", "overwrite", "--subscription-id", subscriptionId, "--resource-group", resourceGroupName);
+        var result = await Bicep(
+            services => services.WithContainerRegistryClientFactory(clientFactory),
+            "snapshot", baselineFolder.EntryFile.OutputFilePath, "--mode", "overwrite", "--subscription-id", subscriptionId, "--resource-group", resourceGroupName);
         result.Should().Succeed();
 
         snapshotFile.ShouldHaveExpectedJsonValue();

src/Bicep.Cli/Helpers/Snapshot/SnapshotHelper.cs

@@ -8,6 +8,7 @@
 using System.Text.Json.Serialization;
 using Azure.Deployments.Core.Configuration;
 using Azure.Deployments.Core.Definitions;
+using Azure.Deployments.Core.Definitions.Extensibility;
 using Azure.Deployments.Core.Definitions.Schema;
 using Azure.Deployments.Core.Entities;
 using Azure.Deployments.Engine.Definitions;
@@ -72,7 +73,13 @@ public static async Task<Snapshot> GetSnapshot(
         return new(
             [
                 .. expansionResult.preflightResources.Select(x => JsonElementFactory.CreateElement(JsonExtensions.ToJson(DeploymentPreflightResourceWithParsedExpressions.From(x)))),
-                .. expansionResult.extensibleResources.Select(x => JsonElementFactory.CreateElement(JsonExtensions.ToJson(x))),
+                .. expansionResult.extensibleResources.Select(x => JsonElementFactory.CreateElement(JsonExtensions.ToJson(new DeploymentWhatIfExtensibleResource
+                    {
+                        Type = x.Type,
+                        ApiVersion = x.ApiVersion,
+                        Identifiers = x.Identifiers?.ToObject<JObject>(),
+                        Properties = x.Properties?.ToObject<JObject>(),
+                    }))),
             ],
             [
                 .. expansionResult.diagnostics.Select(d => $"{d.Target} {d.Level} {d.Code}: {d.Message}")

src/Bicep.Core.UnitTests/Utils/ExtensionTestHelper.cs

@@ -29,11 +29,11 @@ public static ServiceBuilder GetServiceBuilder(
             .WithContainerRegistryClientFactory(clientFactory);
     }
 
-    public static Task<ServiceBuilder> GetServiceBuilderWithPublishedExtension(BinaryData tgzData, FeatureProviderOverrides features, IFileSystem? fileSystem = null)
-        => GetServiceBuilderWithPublishedExtension(new ExtensionPackage(tgzData, false, []), "example.azurecr.io/extensions/foo:1.2.3", features, fileSystem);
+    public static Task<ServiceBuilder> GetServiceBuilderWithPublishedExtension(BinaryData tgzData, FeatureProviderOverrides features, IFileSystem? fileSystem = null, string? artifactTarget = null)
+        => GetServiceBuilderWithPublishedExtension(new ExtensionPackage(tgzData, false, []),  artifactTarget ?? "example.azurecr.io/extensions/foo:1.2.3", features, fileSystem);
 
-    public static Task<ServiceBuilder> GetServiceBuilderWithPublishedExtension(ExtensionPackage package, FeatureProviderOverrides features, IFileSystem? fileSystem = null)
-        => GetServiceBuilderWithPublishedExtension(package, "example.azurecr.io/extensions/foo:1.2.3", features, fileSystem);
+    public static Task<ServiceBuilder> GetServiceBuilderWithPublishedExtension(ExtensionPackage package, FeatureProviderOverrides features, IFileSystem? fileSystem = null, string? artifactTarget = null)
+        => GetServiceBuilderWithPublishedExtension(package, artifactTarget ?? "example.azurecr.io/extensions/foo:1.2.3", features, fileSystem);
 
     public static async Task<ServiceBuilder> GetServiceBuilderWithPublishedExtension(ExtensionPackage package, string target, FeatureProviderOverrides features, IFileSystem? fileSystem = null)
     {