Fix test failures

Author: jeskew

src/Bicep.Core.Samples/Files/baselines/InvalidOutputs_CRLF/Completions/decorators.json

@@ -238,26 +238,5 @@
       "range": {},
       "newText": "secure()$0"
     }
-  },
-  {
-    "label": "validate",
-    "kind": "function",
-    "documentation": {
-      "kind": "markdown",
-      "value": "```bicep\nvalidate(predicate: any => bool, [errorMessage: string]): any\n\n```  \n  \n"
-    },
-    "deprecated": false,
-    "preselect": false,
-    "sortText": "3_validate",
-    "insertTextFormat": "snippet",
-    "insertTextMode": "adjustIndentation",
-    "textEdit": {
-      "range": {},
-      "newText": "validate($0)"
-    },
-    "command": {
-      "title": "signature help",
-      "command": "editor.action.triggerParameterHints"
-    }
   }
 ]

src/Bicep.Core.Samples/Files/baselines/InvalidOutputs_CRLF/Completions/decoratorsPlusNamespace.json

@@ -256,26 +256,5 @@
       "title": "symbol completion",
       "command": "editor.action.triggerSuggest"
     }
-  },
-  {
-    "label": "validate",
-    "kind": "function",
-    "documentation": {
-      "kind": "markdown",
-      "value": "```bicep\nvalidate(predicate: any => bool, [errorMessage: string]): any\n\n```  \n  \n"
-    },
-    "deprecated": false,
-    "preselect": false,
-    "sortText": "3_validate",
-    "insertTextFormat": "snippet",
-    "insertTextMode": "adjustIndentation",
-    "textEdit": {
-      "range": {},
-      "newText": "validate($0)"
-    },
-    "command": {
-      "title": "signature help",
-      "command": "editor.action.triggerParameterHints"
-    }
   }
 ]

src/Bicep.Core.Samples/Files/baselines/InvalidParameters_LF/Completions/intParameterDecorators.json

@@ -103,26 +103,5 @@
       "title": "signature help",
       "command": "editor.action.triggerParameterHints"
     }
-  },
-  {
-    "label": "validate",
-    "kind": "function",
-    "documentation": {
-      "kind": "markdown",
-      "value": "```bicep\nvalidate(predicate: any => bool, [errorMessage: string]): any\n\n```  \n  \n"
-    },
-    "deprecated": false,
-    "preselect": false,
-    "sortText": "3_validate",
-    "insertTextFormat": "snippet",
-    "insertTextMode": "adjustIndentation",
-    "textEdit": {
-      "range": {},
-      "newText": "validate($0)"
-    },
-    "command": {
-      "title": "signature help",
-      "command": "editor.action.triggerParameterHints"
-    }
   }
 ]

src/Bicep.Core.Samples/Files/baselines/InvalidParameters_LF/Completions/intParameterDecoratorsPlusNamespace.json

@@ -121,26 +121,5 @@
       "title": "symbol completion",
       "command": "editor.action.triggerSuggest"
     }
-  },
-  {
-    "label": "validate",
-    "kind": "function",
-    "documentation": {
-      "kind": "markdown",
-      "value": "```bicep\nvalidate(predicate: any => bool, [errorMessage: string]): any\n\n```  \n  \n"
-    },
-    "deprecated": false,
-    "preselect": false,
-    "sortText": "3_validate",
-    "insertTextFormat": "snippet",
-    "insertTextMode": "adjustIndentation",
-    "textEdit": {
-      "range": {},
-      "newText": "validate($0)"
-    },
-    "command": {
-      "title": "signature help",
-      "command": "editor.action.triggerParameterHints"
-    }
   }
 ]

src/Bicep.Core.Samples/Files/baselines/InvalidParameters_LF/Completions/stringParameterDecorators.json

@@ -120,26 +120,5 @@
       "range": {},
       "newText": "secure()$0"
     }
-  },
-  {
-    "label": "validate",
-    "kind": "function",
-    "documentation": {
-      "kind": "markdown",
-      "value": "```bicep\nvalidate(predicate: any => bool, [errorMessage: string]): any\n\n```  \n  \n"
-    },
-    "deprecated": false,
-    "preselect": false,
-    "sortText": "3_validate",
-    "insertTextFormat": "snippet",
-    "insertTextMode": "adjustIndentation",
-    "textEdit": {
-      "range": {},
-      "newText": "validate($0)"
-    },
-    "command": {
-      "title": "signature help",
-      "command": "editor.action.triggerParameterHints"
-    }
   }
 ]

src/Bicep.Core.Samples/Files/baselines/InvalidParameters_LF/Completions/stringParameterDecoratorsPlusNamespace.json

@@ -138,26 +138,5 @@
       "title": "symbol completion",
       "command": "editor.action.triggerSuggest"
     }
-  },
-  {
-    "label": "validate",
-    "kind": "function",
-    "documentation": {
-      "kind": "markdown",
-      "value": "```bicep\nvalidate(predicate: any => bool, [errorMessage: string]): any\n\n```  \n  \n"
-    },
-    "deprecated": false,
-    "preselect": false,
-    "sortText": "3_validate",
-    "insertTextFormat": "snippet",
-    "insertTextMode": "adjustIndentation",
-    "textEdit": {
-      "range": {},
-      "newText": "validate($0)"
-    },
-    "command": {
-      "title": "signature help",
-      "command": "editor.action.triggerParameterHints"
-    }
   }
 ]

src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs

@@ -1946,11 +1946,10 @@ public Diagnostic EnvironmentVariableDoesNotExist(string name, string? suggestio
                 "BCP427",
                 $"Environment variable \"{name}\" does not exist and there's no default value set.{suggestion}");
 
-            public Diagnostic RuntimeValueNotAllowedInFunctionArgument((string?, string?) parameterMetadata, string? accessedSymbolName, IEnumerable<string>? accessiblePropertyNames, IEnumerable<string>? variableDependencyChain)
+            public Diagnostic RuntimeValueNotAllowedInFunctionArgument(string? functionName, string? parameterName, string? accessedSymbolName, IEnumerable<string>? accessiblePropertyNames, IEnumerable<string>? variableDependencyChain)
             {
                 var variableDependencyChainClause = BuildVariableDependencyChainClause(variableDependencyChain);
                 var accessiblePropertiesClause = BuildAccessiblePropertiesClause(accessedSymbolName, accessiblePropertyNames);
-                var (functionName, parameterName) = parameterMetadata;
 
                 return CoreError(
                     "BCP428",

src/Bicep.Core/TypeSystem/DeployTimeConstantViolationVisitor.cs

@@ -59,11 +59,13 @@ ForSyntax forSyntax when ErrorSyntaxInForBodyOfVariable(forSyntax, errorSyntax)
                 ForSyntax => diagnosticBuilder.RuntimeValueNotAllowedInForExpression(accessedSymbolName, accessiblePropertyNames, variableDependencyChain),
                 FunctionCallSyntaxBase functionCallSyntaxBase => diagnosticBuilder.RuntimeValueNotAllowedInRunTimeFunctionArguments(functionCallSyntaxBase.Name.IdentifierName, accessedSymbolName, accessiblePropertyNames, variableDependencyChain),
                 FunctionDeclarationSyntax => diagnosticBuilder.RuntimeValueNotAllowedInFunctionDeclaration(accessedSymbolName, accessiblePropertyNames, variableDependencyChain),
-                FunctionArgumentSyntax arg => diagnosticBuilder.RuntimeValueNotAllowedInFunctionArgument(
-                    GetFunctionAndParameterName(arg),
-                    accessedSymbolName,
-                    accessiblePropertyNames,
-                    variableDependencyChain),
+                FunctionArgumentSyntax arg when GetFunctionAndParameterName(arg) is { } parameterMetadata
+                    => diagnosticBuilder.RuntimeValueNotAllowedInFunctionArgument(
+                        parameterMetadata.functionName,
+                        parameterMetadata.parameterName,
+                        accessedSymbolName,
+                        accessiblePropertyNames,
+                        variableDependencyChain),
                 _ => throw new ArgumentOutOfRangeException(nameof(this.DeployTimeConstantContainer), "Expected an ObjectPropertySyntax with a propertyName, an IfConditionSyntax, a ForSyntax, a FunctionCallSyntaxBase, or a FunctionDeclarationSyntax."),
             };